MTreatmentOutletFlowData.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-SUNRISE
UI-DEN-SUNRISE
UI Release/p1_staging Unreviewed Commits
UI Release/p1_staging Unreviewed Commits
UI DEN-16614: UI-DN-S114-Msg-Update
UI DEN-16614: UI-DN-S114-Msg-Update
RESOLVED

RESOLVED

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

RESOLVED

RESOLVED

Resolved and tested.

Resolved and tested.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

As far as I see there is MTreatmentOutletFlowData.cpp do ctrl+k,p MTreatmentOutletFlowData or ctrl+shift, MTreatmentOutletFlowData or F4 in your MTreatmentOutletFlowData.h to get in the cpp file to...

As far as I see there is MTreatmentOutletFlowData.cpp
do ctrl+k,p MTreatmentOutletFlowData
or ctrl+shift, MTreatmentOutletFlowData
or F4 in your MTreatmentOutletFlowData.h to get in the cpp file
to find it.

RESOLVED

RESOLVED

Added

Added

Removed conversion

Removed conversion

Added.

Added.

Done.

Done.

There is no CPP for this file. Unless you meant a different location

There is no CPP for this file. Unless you meant a different location

update the length check of the message in MessageGlobals.h const QHash<Gui::GuiActionType ,quint8> payloadLen { . . {Gui::GuiActionType::ID_DialysateOutletFlow , 10 * 4 }...

update the length check of the message in MessageGlobals.h

const QHash<Gui::GuiActionType ,quint8> payloadLen {
.
.
{Gui::GuiActionType::ID_DialysateOutletFlow                     ,  10 * 4       }, //10 parameters each 4bytes
.
.
}
param 11 is missing 01 F32-refUFVolMl 02 F32-measUFVolMl 03 F32-measRotSpdRPM 04 F32-measSpdRPM 05 F32-measMCSpdRPM ...

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate          
param 11 is missing 01 F32-refUFVolMl 02 F32-measUFVolMl 03 F32-measRotSpdRPM 04 F32-measSpdRPM 05 F32-measMCSpdRPM ...

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate          

I think we should use mL/min as is. and do not convert to Liter.

I think we should use mL/min as is. and do not convert to Liter.