Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated MAlarmMapping.cpp

Do you still need this case?

Do you still need this case?

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Thanks.

Thanks.

That is a very good question. As much as possible we have to put the #includes in the CPP files and not the header. The #include in the header will always be imported even if you don't compile the ...

That is a very good question.
As much as possible we have to put the #includes in the CPP files and not the header.
The #include in the header will always be imported even if you don't compile the code (only CPP is compiled in c, not the header) as opposed to just including when needed to compile in CPP.
This also helps the compiler to optimize the code better and faster to compile.
you only need to put it in the header if you inherit from the class defined in the class included or you have a variable/parameter defined of that file in the header.

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

These changes have been requested by SysEngz. Let them have a look and decide if it's what they want.

These changes have been requested by SysEngz.
Let them have a look and decide if it's what they want.

RESOLVED

RESOLVED

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

This file was changed but no changes are highlighted, any idea what happened?

This file was changed but no changes are highlighted, any idea what happened?

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file? Edit: I understand that BluetoothInterface.h is need...

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file?

Edit: I understand that BluetoothInterface.h is needed, but what about the others?

Bamboo Commit: Updated MAlarmMapping.cpp

This is calling didAttributeResponse from DeviceGlobals.h, correct?

This is calling didAttributeResponse from DeviceGlobals.h, correct?

is $PAIRED_DEVICE_INFO an environment variable?

is $PAIRED_DEVICE_INFO an environment variable?

Bamboo Commit: Updated MAlarmMapping.cpp

Fixed. Thanks for your attention to the details.

Fixed.
Thanks for your attention to the details.

Bamboo Commit: Updated MAlarmMapping.cpp

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated MAlarmMapping.cpp

Added

Added

Needs function header?

Needs function header?

RESOLVED

RESOLVED

that is fine because...

that is fine because...

it is a test for the code review demo

it is a test for the code review demo

DEN-11380 KeborMed [ CloudSync Development ]

- modified the messaging protocol to the below and reordered the crc position.

<timestamp>,<seq>,<CRC=0 for now, Don't care>,<message id>,<parameter length>[,<P1>,...<Pn>]

  1. … 2 more files in changeset.
Merge branch 'DEN-10205_BCuff_MissingFeatures_Reconnect_Paired' into develop

  1. … 3 more files in changeset.
Added a step in the application build to run the alarmMapping automatically

  1. … 1 more file in changeset.