Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
RESOLVED [~vduong], When fixed please don't use "resolved", it is a keyword for our Bamboo scripts. Thanks,

RESOLVED
[~vduong], When fixed please don't use "resolved", it is a keyword for our Bamboo scripts.
Thanks,

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 43 more files in changeset.
RESOLVED.

RESOLVED.

CR: Addressing Code Review comment UI-DEN-14936-1#c16985

http://devapps.diality.us:8060/cru/UI-DEN-14936-1#c16985

Thanks, Will update my comment.

Thanks,
Will update my comment.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Your comment has ???. Trying to help.

Your comment has ???. Trying to help.

Bamboo Commit: Updated MAlarmMapping.cpp

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
Fixed too.

Fixed too.

Great catch, Thank a lot Sean for catching that. It is fixed.

Great catch,
Thank a lot Sean for catching that.
It is fixed.

CR: Addressing Code Review comment UI-DEN-14936-1#c16983

http://devapps.diality.us:8060/cru/UI-DEN-14936-1#c16983

    • -40
    • +40
    ./dg/data/MDGConductivityData.cpp
Not clear what you want me to do here?

Not clear what you want me to do here?

DEN-14955 Tx Create Rejection - Include the type buttons' reject reason - Modify to make gridSelection title color changeable

  1. … 4 more files in changeset.
In post-treatment, there are a few states to work through to ensure reservoirs get drained: /* Post-Treatment drain reservoirs state machine. */ typedef enum Drain_States { DRAIN_DG_DEPRIME_STATE ...

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

Resolved.

Resolved.

Please use Changed and align

Please use Changed
and align

DEN-14853 UI Out Of Sync With Firmware On Handled Messages

  1. … 9 more files in changeset.
DEN-14853 UI Out Of Sync With Firmware On Handled Messages

  1. … 4 more files in changeset.