application / sources / storage

settings.cpp._

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 15 Oct 2020
10:16 am

Behrouz NematiPour

10:16 am

Behrouz NematiPour

Wednesday 14 Oct 2020
11:09 pm

pmontazemi  (deleted user) and plucia  (deleted user)

11:07 pm

pmontazemi  (deleted user) and plucia  (deleted user)

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:44 am

plucia  (deleted user)

RESOLVED. Fair, not related to story

RESOLVED.

Fair, not related to story

10:43 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:43 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:42 am

plucia  (deleted user)

Fair, not related to story. RESOLVED.

Fair, not related to story.

RESOLVED.

10:40 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:40 am

plucia  (deleted user)

Fair, not related to story. RESOLVED.

Fair, not related to story.

RESOLVED.

10:39 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:38 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:35 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:34 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:34 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:33 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:32 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:31 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:29 am

plucia  (deleted user)

RESOLVED

RESOLVED

Tuesday 13 Oct 2020
6:07 pm

Behrouz NematiPour

did

did

6:04 pm

Behrouz NematiPour

It is all documentations and Doxygenization. If you see otherwise is because of the some file name change and the code review take it as a new file and mark all the file content as to be reviewed. ...

It is all documentations and Doxygenization.
If you see otherwise is because of the some file name change and the code review take it as a new file and mark all the file content as to be reviewed.
Let me know if otherwise.

6:01 pm

Behrouz NematiPour

Please refer to the newer code review after the max revision has been changed which has all the latest commits. http://192.168.10.132:8060/cru/UI-DEN-4690-2-1 Seems like it has appeared here as well.

Please refer to the newer code review after the max revision has been changed which has all the latest commits.
http://192.168.10.132:8060/cru/UI-DEN-4690-2-1
Seems like it has appeared here as well.

6:00 pm

Behrouz NematiPour

"*** Off the subject ***" This is not related to the story and is a code coverage of another story. Regardless it was decided to manually test the CANBus at that moment since it could be better tes...

"*** Off the subject ***"
This is not related to the story and is a code coverage of another story.
Regardless it was decided to manually test the CANBus at that moment since it could be better tested with more accurate results which all of those test couldn't be achieved manually and took a long time to test because 10 or 100 of thousands of frames tested and wasn't reasonable to do it each time automatically on server with virtual CANBus and had to be tested on a real physical CANBus.
I hope this is enough information!

5:59 pm

Behrouz NematiPour

DISABLE_CRC is only for development debugging purposes. and is not part of this function definition. Will be defined/enabled in case for debugging.

DISABLE_CRC is only for development debugging purposes.
and is not part of this function definition.
Will be defined/enabled in case for debugging.

5:58 pm

Behrouz NematiPour

I think if it's not false (false if the vData of type QByteArray is not sufficient regarding vAction) then it would be true, right ?!

I think if it's not false (false if the vData of type QByteArray is not sufficient regarding vAction) then it would be true, right ?!

5:57 pm

Behrouz NematiPour

"*** Off the subject **" There are tests (manually/automatically) for that and the application quits properly. If terminates by SquishCoco or being killed in the terminal may not have time to clea...

"*** Off the subject **"

There are tests (manually/automatically) for that and the application quits properly.
If terminates by SquishCoco or being killed in the terminal may not have time to clean up correctly.
When shuts down by user within the UI by user quits nicely and clean.

"** Also please don't check "Needs resolution" for every comment you make, it happened many times regardless of mentioning it multiple times ***"

5:56 pm

Behrouz NematiPour

"*** Off the subject ***" At the time of testing application with SquishCoco, observed that Coco can't safely quit application and terminates the application and don't call the correct quit method ...

"*** Off the subject ***"
At the time of testing application with SquishCoco, observed that Coco can't safely quit application and terminates the application and don't call the correct quit method of the application and that makes sense since the Squish Coco is another application and will immediately terminate the UI application and don't know how to properly quit the UI application.
So UI application can't safely quit the threads.
Therefore some threading features has been manually tested.
The quitThread in each class is basically should name moveThread (move to main thread).

I hope this is enough information !

Wednesday 07 Oct 2020
11:06 pm

Behrouz NematiPour

"*** Off the subject ***" I don't have any plans for that. It was an effort to feel the gap of not having the corresponding FW code at that moment. If it happens again will consider improving the c...

"*** Off the subject ***"
I don't have any plans for that.
It was an effort to feel the gap of not having the corresponding FW code at that moment.
If it happens again will consider improving the code otherwise we need to consolidate with our manager for priorities/planning.

11:05 pm

Behrouz NematiPour

"*** Off the subject ***" AGAIN, I don't understand what is the relevance of the comment to the Story and which part of the code this comment is referring to?

"*** Off the subject ***"
AGAIN,
I don't understand what is the relevance of the comment to the Story and which part of the code this comment is referring to?