application / sources / view / hd / data

VTreatmentRanges.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 10 Feb
3:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./VTreatmentRanges.h
  2. … 619 more files in changeset.
Thursday 30 Jan
8:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./VTreatmentRanges.h
  2. … 619 more files in changeset.
Wednesday 24 Jan 2024
2:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./VTreatmentRanges.h
  2. … 612 more files in changeset.
Thursday 18 Jan 2024
10:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./VTreatmentRanges.h
  2. … 612 more files in changeset.
Tuesday 08 Aug 2023
2:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./VTreatmentRanges.h
  2. … 14 more files in changeset.
1:45 pm

vduong  (deleted user)

1:44 pm

Behrouz NematiPour and Tiffany Mejia

11:46 am

Behrouz NematiPour

Sunday 06 Aug 2023
7:54 pm

msuleiman  (deleted user)

7:53 pm

msuleiman  (deleted user)

6:41 pm

Behrouz NematiPour

UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
6:20 pm

Behrouz NematiPour

DEN-15487: Updated - UI: POST: UI needs to report an error if the configuration files, or parameter(s) are missing.

DEN-16104: UI: Reorder the sequence of the messages in POST from UI to HD

Options
    • -1
    • +1
    ./VTreatmentRanges.h
  2. … 13 more files in changeset.
Thursday 03 Aug 2023
2:23 pm

Sean Nash

2:05 pm

Dara Navaei

Wednesday 02 Aug 2023
9:33 am

Sean Nash

Tuesday 01 Aug 2023
6:24 pm

Behrouz NematiPour

Thanks for reminding me the situation with the comment. that is right in View classes we need to. maybe later we can move these checks all in the settings controller, from this view. RESOLVED.

Thanks for reminding me the situation with the comment.
that is right in View classes we need to.
maybe later we can move these checks all in the settings controller, from this view.

RESOLVED.

6:23 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:21 pm

Behrouz NematiPour

RESOLVED

RESOLVED

Friday 28 Jul 2023
5:36 am

vduong  (deleted user)

Changed

Changed

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Changed based on how GuiView handles the connection from a created-in-QML object.

Changed based on how GuiView handles the connection from a created-in-QML object.

5:00 am

vduong  (deleted user)

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

1:46 am

Behrouz NematiPour

this is incorrect connection usage. it should be moved to the applicationController class. The rule of API design: *the API is just emitting the signal *and is not responsible for the usage. *an...

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

1:41 am

Behrouz NematiPour

please check, lists are not empty. can be checked by private member variable: isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

please check, lists are not empty.
can be checked by private member variable: 

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
1:38 am

Behrouz NematiPour

add an empty line before and after

add an empty line before and after

1:34 am

Behrouz NematiPour

please align SIGNAL(did SLOT( on

please align
SIGNAL(did
SLOT( on

1:33 am

Behrouz NematiPour

please do not use else. make it like the others on top. Look at lines 79 - 83. And insert it in between lines 89,90 with two empty line on top and bottom of the if block if ( ! codition ) { err ...

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block 

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks