application / sources

view

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 03 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Jan 2022
8:55 pm

Behrouz NematiPour

DEN-9704: Missing acknowledgement confirmation message/alarm when leaving BP/HR blank

- A typo caused the BP/HR entry timer disabled.

Options
    • -4
    • +4
    ./hd/adjustment/common/VCommonAdjustmentVitals.cpp
  2. … 1 more file in changeset.
9:35 am

Behrouz NematiPour

That is a very good point. No one ever mentioned that. Let me investigate, why I had all these repeated else. Could be for performance not to check next, but there is another way for that too. If ...

That is a very good point.
No one ever mentioned that.

Let me investigate, why I had all these repeated else.
Could be for performance not to check next, but there is another way for that too.
If I can't find a quick answer for that let me create a case for that since it is everywhere.

9:32 am

Dara Navaei

RESOLVED.

RESOLVED.

9:29 am

Behrouz NematiPour

There has to be and there is. It is just a long line and those little ones are at the end.

There has to be and there is.
It is just a long line and those little ones are at the end.

Tuesday 18 Jan 2022
9:00 pm

Dara Navaei

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

8:57 pm

Dara Navaei

Isn't is safer to have a break at the end of each case?

Isn't is safer to have a break at the end of each case?

7:49 pm

Behrouz NematiPour

DEN-11814: Heparin Minimum Dispensing Parameters Should Be 0.2

- updated the min range regarding the recent PRS-347, PRS-348

- Fixed the minimum precision of the heparin.

Options
    • -2
    • +2
    ./VTreatmentCreate.h
  2. … 4 more files in changeset.
7:26 pm

Behrouz NematiPour

DEN-10422: Dialysate Flow Rate maximum rate selectable in Treatment does not meet PRS resolution

Options
    • -62
    • +61
    ./VTreatmentCreate.h
    • -4
    • +5
    ./hd/data/VTreatmentRanges.cpp
6:47 pm

Behrouz NematiPour

DEN-8145: Issues with UI Create Treatment screen

Remainder items (summary):

- 3) Discuss whether to keep the manufacturing default on the slider since the user needs to confirm each parameter: Agreed to set to the minimum value

- 7) Arterial Pressure and Venous Pressure should be consistent with other parameters, the unit should be shown at the end: will be updated to have the units located in the title of the slider.

- Also fixed the title coloring when the slider has not been adjusted yet.

Options
    • -14
    • +14
    ./VTreatmentCreate.h
  2. … 4 more files in changeset.
1:46 pm

Dara Navaei

1:46 pm

Dara Navaei

UI-BUG-S62
UI-BUG-S62
Friday 14 Jan 2022
6:09 pm

Behrouz NematiPour

DEN-9704: Missing acknowledgement confirmation message/alarm when leaving BP/HR blank

- Added a script to later be used for the log export on the device, but it now only works on the VM since the device doesn't have the zip tool.

- Added a mimic function to simulate the BCuff measurement received and assigned F11 to it and it will only be enabled if the macro DEBUG_BCUFF_MIMIC is defined.

- Added opened and closed signals to the EntryDialog.qml to make it do the auto focus on the firstInput object when opened.

- Added setFocus() function in the BPHREntry.qml

- Removed the enabled option from doReset of the VTreatmentVitals

- And created two separate enableDialog for vital entry, and enable update for the auto update the properties.

- Added a constructor with systolic, diastolic, heartRate parameter to set the data on creation to be used in the message mimic.

- Added systolic, diastolic, heartRate parameters to the doTrigger of the VCommonAdjustmentVitals to open the vitals entry dialog with default values.

Options
    • -4
    • +19
    ./VEventSpy.cpp
    • -16
    • +21
    ./hd/adjustment/common/VCommonAdjustmentVitals.cpp
    • -3
    • +4
    ./hd/adjustment/common/VCommonAdjustmentVitals.h
  4. … 13 more files in changeset.
5:19 pm

Behrouz NematiPour

Code Cleanup

- DEN-11807: Treatment Confirmation - Rinseback Rate displays "min" instead of "mL/min"

- Renamed the Keyboard component name to VirtualKeyboard to resolve the InputPanel's Keyboard object/type conflict (There was no issue is was only a name conflict.)

- Preventing the Patient Id from being empty space string, and disabling the confirm in that case.

- Mode the create_update_folder.sh to the Scripts/local repository's folder.

- Added Qt logo and Diality Qt Colored log.

- Updated the alarmMapping.sh script to always checkout to common/staging and also print out the log on console.

-

Options
    • -1
    • +1
    ./VTreatmentCreate.cpp
  2. … 12 more files in changeset.
Wednesday 05 Jan 2022
11:45 am

Behrouz NematiPour

Monday 03 Jan 2022
1:57 pm

Dara Navaei

1:57 pm

Dara Navaei

In the firmware we add a TODO to be able to grep them easily and make sure we do not forget any commented code. RESOLVED.

In the firmware we add a TODO to be able to grep them easily and make sure we do not forget any commented code.
RESOLVED.

1:56 pm

Dara Navaei

RESOLVED.

RESOLVED.

1:55 pm

Dara Navaei

RESOLVED.

RESOLVED.

1:55 pm

Dara Navaei

Sorry I meant parameters not arguments.

Sorry I meant parameters not arguments.

1:54 pm

Dara Navaei

RESOLVED.

RESOLVED.

12:37 pm

Behrouz NematiPour

Thursday 30 Dec 2021
9:37 am

Sean Nash

9:36 am

Sean Nash

RESOLVED.

RESOLVED.

Wednesday 22 Dec 2021
12:57 pm

Michael Garthwaite

12:57 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

Thank you!

Thank you!

11:25 am

Behrouz NematiPour

A very important concept. I refer you to the Qt connection concept for detailed information. https://doc.qt.io/qt-5/signalsandslots.html The idea is, the connect has 4 parameter 1 - Signal owner ob...

A very important concept.
I refer you to the Qt connection concept for detailed information.
https://doc.qt.io/qt-5/signalsandslots.html
The idea is, the connect has 4 parameter
1 - Signal owner object
2 - Signal member function
3 - Slot owner object
4 - Slot member function
When the signal owner is emit-ed, the slot owner will call its slot by the passed parameter from the signal function.
It is very important to use the connection concept, in opposed to the simple call, in case the signal owner and slot owner, objects, are in two different threads.
It is the Qt way of thread-safe calling.

11:11 am

Behrouz NematiPour

Ummm, Haven't ever thought about it, this is a very good point. Will look into it, since the actual friend class will not ever be available in the production code.

Ummm,
Haven't ever thought about it, this is a very good point.
Will look into it, since the actual friend class will not ever be available in the production code.