application

sources

Clone Tools

Stats

Commits this week: 2
Total Committers: 14
Last Commit: 17:14
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Jan 2021
5:55 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -4
    • +4
    ./gui/qml/main.qml
5:49 pm

Behrouz NematiPour

This is my comment and it is specific to the exact line below the comment. Please revert it back to be able to identify which line in the code it refers to. "This code review includes so many unre...

This is my comment and it is specific to the exact line below the comment.
Please revert it back to be able to identify which line in the code it refers to.

"This code review includes so many unrelated branched to the code review subject"
look at the list of the commits and branches included in this page
http://dvm-linux02:8060/project/UI-DEN-6349?max=100&projectKey=UI-DEN-6349&view=fe

5:48 pm

plucia  (deleted user)

acceptableInput is a property of the TextInput component. The TextInput component in TextEntry is accessed via the textInput alias

acceptableInput is a property of the TextInput component.
The TextInput component in TextEntry is accessed via the textInput alias

5:41 pm

plucia  (deleted user)

This is your change actually. It looks like you added this in 45ce6e78 The alarm colors won't work without it

This is your change actually. It looks like you added this in 45ce6e78
The alarm colors won't work without it

5:39 pm

Behrouz NematiPour

where the acceptableInput comes from the TextEntry component doesn't have such a property?

where the acceptableInput comes from the TextEntry component doesn't have such a property?

5:29 pm

Behrouz NematiPour

RESOLVED

RESOLVED

5:28 pm

Behrouz NematiPour

Why this is imported?

Why this is imported?

5:27 pm

Behrouz NematiPour

RESOLVED

RESOLVED

5:27 pm

plucia  (deleted user)

When I removed the keyboard styling I removed this variable as well

When I removed the keyboard styling I removed this variable as well

5:27 pm

Behrouz NematiPour

RESOLVED

RESOLVED

5:26 pm

Behrouz NematiPour

RESOLVED

RESOLVED

5:26 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:51 pm

plucia  (deleted user)

It's in the UX design here: https://app.zeplin.io/project/5e160353a7c41a9404596a70/screen/5e5060d3f75589612aee8b68

It's in the UX design here: https://app.zeplin.io/project/5e160353a7c41a9404596a70/screen/5e5060d3f75589612aee8b68

4:50 pm

plucia  (deleted user)

See response above

See response above

4:50 pm

plucia  (deleted user)

See response above

See response above

4:50 pm

plucia  (deleted user)

See response above

See response above

4:50 pm

plucia  (deleted user)

See response above

See response above

4:50 pm

plucia  (deleted user)

This objectName is necessary for the added alarm tests to work, which also guarantees 100% code coverage on my branch It is very helpful for Systems / SW V&V to have as many object names defined so...

This objectName is necessary for the added alarm tests to work, which also guarantees 100% code coverage on my branch
It is very helpful for Systems / SW V&V to have as many object names defined so they can write their own squishqt tests
In order for Systems / SW V&V to interact with the alarms and so the alarm tests can function, I think it should be kept

4:50 pm

plucia  (deleted user)

Having a separate component prevents alerts from covering up alarms and ensures the alarm takes precedence

Having a separate component prevents alerts from covering up alarms and ensures the alarm takes precedence

4:49 pm

plucia  (deleted user)

This isn't a change I had made. You added this in cd769413344091cea88a30861b49188c8c147cba I don't know why it's showing up here. Seems like crucible messed up Do you want me to remove it anyway?

This isn't a change I had made.
You added this in cd769413344091cea88a30861b49188c8c147cba
I don't know why it's showing up here. Seems like crucible messed up
Do you want me to remove it anyway?

4:49 pm

plucia  (deleted user)

Done

Done

4:49 pm

plucia  (deleted user)

Done

Done

4:49 pm

plucia  (deleted user)

This folder contains treatment related information such as parameter ranges as well as paired BLE devices. Would you prefer we store the bluetooth devices in a separate folder called bluetooth inst...

This folder contains treatment related information such as parameter ranges as well as paired BLE devices.
Would you prefer we store the bluetooth devices in a separate folder called bluetooth instead?

4:49 pm

plucia  (deleted user)

"connmand" is correct It's used to manage internet connections on embedded devices and causes problems if it is already running while bluetooth is starting up

"connmand" is correct
It's used to manage internet connections on embedded devices and causes problems if it is already running while bluetooth is starting up

4:49 pm

plucia  (deleted user)

Done

Done

4:48 pm

plucia  (deleted user)

Done - Updated to use iArrow now

Done - Updated to use iArrow now

4:48 pm

plucia  (deleted user)

Done

Done

4:47 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -4
    • +0
    ./gui/qml/components/ScreenItem.qml
    • -21
    • +8
    ./gui/qml/components/SettingsItem.qml
    • -0
    • +3
    ./gui/qml/globals/Variables.qml
  4. … 3 more files in changeset.
11:47 am

Behrouz NematiPour

same

same

11:47 am

Behrouz NematiPour

Please move it after # CANBus section.

Please move it after # CANBus section.