application

sources

Clone Tools

Stats

Commits this week: 1
Total Committers: 14
Last Commit: 17 Apr
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Aug 2021
1:48 pm

Behrouz NematiPour

DEN-9418: Code Review 0

Options
    • -1
    • +2
    ./canbus/MessageDispatcher.cpp
    • -18
    • +18
    ./canbus/MessageGlobals.h
    • -1
    • +0
    ./gui/qml/components/DebugDataColumn.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentStack.qml
  5. … 1 more file in changeset.
1:35 pm

Behrouz NematiPour

It has only one parameter and is 15 bytes long. By definition, it is different than the others. 0x9900 153 0x020 Rsp Y HD UI HD serial number ASCII text - 15 bytes, not null term 0x8800 136 0x070...

It has only one parameter and is 15 bytes long.
By definition, it is different than the others.

0x9900 153 0x020 Rsp Y HD UI HD serial number ASCII text - 15 bytes, not null term
0x8800 136 0x070 Rsp Y DG UI DG serial number ASCII text - 15 bytes, not null term
1:32 pm

Behrouz NematiPour

It is a red line and has already been removed.

It is a red line and has already been removed.

1:21 pm

Sean Nash

If this is test code, add TODO to remove later.

If this is test code, add TODO to remove later.

1:20 pm

Sean Nash

Why not - 40? Can we remove?

Why not - 40? Can we remove?

1:19 pm

Sean Nash

Why commented out? Can we remove?

Why commented out? Can we remove?

1:14 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:09 pm

Sean Nash

Should this be 1 * 15 for consistency?

Should this be 1 * 15 for consistency?

1:08 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:08 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:07 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:07 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:07 pm

Sean Nash

No comment?

No comment?

1:06 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:06 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:03 pm

Sean Nash

Magic number?

Magic number?

12:52 pm

Behrouz NematiPour

This is not the version of the code presented in the demo and now it reads the actual HWClock, not the system clock is being kept by the Linux system. The first one was using the date which has bee...

This is not the version of the code presented in the demo and now it reads the actual HWClock, not the system clock is being kept by the Linux system.
The first one was using the date which has been noted, and it has been changed to the current implementation.

10:44 am

pmontazemi  (deleted user)

1. Replace couldn't with could not; 2. We decided to explore other means to obtain the true RTC clock rather than the MPU's Linux clock. What were the results of that exploration and where is it re...

1. Replace couldn't with could not;
2. We decided to explore other means to obtain the true RTC clock rather than the MPU's Linux clock. What were the results of that exploration and where is it reflected in this code?

Tuesday 10 Aug 2021
1:33 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    ./model/hd/alarm/MAlarmMapping.cpp
1:30 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    ./model/hd/alarm/MAlarmMapping.cpp
12:59 pm

Behrouz NematiPour

DEN-9614: Meetings & Support - General Support

- Trying to have a first run after a while on the unit tests.

Options
    • -1
    • +1
    ./model/hd/alarm/MAlarmTriggered.h
    • -1
    • +1
    ./storage/FileHandler.cpp
  3. … 1 more file in changeset.
11:17 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -3
    • +13
    ./model/hd/alarm/MAlarmMapping.cpp
10:50 am

Behrouz NematiPour

DEN-9649: Implementation - Yocto configuration

- Addressed some frequent code review comments

- Fixed the UI POST AlarmTriggered message

- Added the deleteLater for the QQuickViewer pointer _viewer.

Options
    • -1
    • +1
    ./ApplicationController.cpp
    • -2
    • +2
    ./ApplicationController.h
    • -2
    • +2
    ./ApplicationPost.cpp
    • -1
    • +1
    ./MainTimer.h
    • -16
    • +16
    ./canbus/CanInterface.cpp
    • -4
    • +4
    ./canbus/CanInterface.h
    • -5
    • +5
    ./canbus/FrameInterface.cpp
    • -3
    • +3
    ./canbus/FrameInterface.h
    • -2
    • +2
    ./canbus/MessageAcknowModel.h
    • -18
    • +18
    ./canbus/MessageBuilder.cpp
    • -6
    • +6
    ./canbus/MessageDispatcher.cpp
    • -5
    • +5
    ./canbus/MessageDispatcher.h
    • -5
    • +5
    ./canbus/MessageGlobals.h
    • -8
    • +8
    ./canbus/MessageInterpreter.cpp
    • -1
    • +1
    ./canbus/MessageInterpreter.h
  16. … 100 more files in changeset.
Friday 06 Aug 2021
1:11 pm

Behrouz NematiPour

11:17 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:17 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:17 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:10 am

Behrouz NematiPour

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1

11:10 am

Behrouz NematiPour

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1

11:10 am

Behrouz NematiPour

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1

Has been addressed in : http://dvm-linux02:7990/projects/UI/repos/application/commits/3ad21b53b6b15cc0c88661cf17ba454fe0a302b1