application

sources

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 03 Apr
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Dec 2021
1:41 pm

Dara Navaei

Do you still need this case?

Do you still need this case?

1:29 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:27 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:27 pm

Michael Garthwaite

Thanks.

Thanks.

1:08 pm

Behrouz NematiPour

That is a very good question. As much as possible we have to put the #includes in the CPP files and not the header. The #include in the header will always be imported even if you don't compile the ...

That is a very good question.
As much as possible we have to put the #includes in the CPP files and not the header.
The #include in the header will always be imported even if you don't compile the code (only CPP is compiled in c, not the header) as opposed to just including when needed to compile in CPP.
This also helps the compiler to optimize the code better and faster to compile.
you only need to put it in the header if you inherit from the class defined in the class included or you have a variable/parameter defined of that file in the header.

1:04 pm

Behrouz NematiPour

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

1:03 pm

Behrouz NematiPour

These changes have been requested by SysEngz. Let them have a look and decide if it's what they want.

These changes have been requested by SysEngz.
Let them have a look and decide if it's what they want.

11:30 am

Michael Garthwaite

RESOLVED

RESOLVED

11:20 am

Michael Garthwaite

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

10:26 am

Michael Garthwaite

This file was changed but no changes are highlighted, any idea what happened?

This file was changed but no changes are highlighted, any idea what happened?

10:16 am

Michael Garthwaite

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file? Edit: I understand that BluetoothInterface.h is need...

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file?

Edit: I understand that BluetoothInterface.h is needed, but what about the others?

10:09 am

Michael Garthwaite

This is calling didAttributeResponse from DeviceGlobals.h, correct?

This is calling didAttributeResponse from DeviceGlobals.h, correct?

9:36 am

Michael Garthwaite

is $PAIRED_DEVICE_INFO an environment variable?

is $PAIRED_DEVICE_INFO an environment variable?

Friday 17 Dec 2021
6:45 pm

Behrouz NematiPour

Fixed. Thanks for your attention to the details.

Fixed.
Thanks for your attention to the details.

4:02 pm

Michael Garthwaite

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Tuesday 14 Dec 2021
10:36 am

Behrouz NematiPour

Added

Added

Monday 13 Dec 2021
4:33 pm

Sean Nash

Needs function header?

Needs function header?

4:15 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:14 pm

Behrouz NematiPour

that is fine because...

that is fine because...

4:12 pm

Behrouz NematiPour

it is a test for the code review demo

it is a test for the code review demo

Thursday 09 Dec 2021
5:18 pm

Behrouz NematiPour

5:18 pm

Behrouz NematiPour

5:17 pm

Behrouz NematiPour

5:17 pm

Behrouz NematiPour

9:44 am

Sean Nash

9:44 am

Sean Nash

RESOLVED.

RESOLVED.

Tuesday 30 Nov 2021
4:52 pm

Behrouz NematiPour

These functions are defined by macros and have the comment headers in macro and it has been set up in oxygen to grab the comments from the defined macro and not the implementation. So long story sh...

These functions are defined by macros and have the comment headers in macro and it has been set up in oxygen to grab the comments from the defined macro and not the implementation.
So long story short, the comments for these methods onAttributeRequest & onProcessBluetoothPairedResetExitCode, will be inherited from macros.
They are all overloaded function members (same name different signature)

Monday 29 Nov 2021
12:26 pm

Sean Nash

RESOLVED.

RESOLVED.

12:25 pm

Sean Nash

RESOLVED.

RESOLVED.

12:25 pm

Sean Nash

RESOLVED.

RESOLVED.