application

sources

Clone Tools

Stats

Commits this week: 2
Total Committers: 14
Last Commit: 05 Feb
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Jan 2022
9:35 am

Behrouz NematiPour

That is a very good point. No one ever mentioned that. Let me investigate, why I had all these repeated else. Could be for performance not to check next, but there is another way for that too. If ...

That is a very good point.
No one ever mentioned that.

Let me investigate, why I had all these repeated else.
Could be for performance not to check next, but there is another way for that too.
If I can't find a quick answer for that let me create a case for that since it is everywhere.

9:32 am

Dara Navaei

RESOLVED.

RESOLVED.

9:29 am

Behrouz NematiPour

There has to be and there is. It is just a long line and those little ones are at the end.

There has to be and there is.
It is just a long line and those little ones are at the end.

Tuesday 18 Jan 2022
9:00 pm

Dara Navaei

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

8:57 pm

Dara Navaei

Isn't is safer to have a break at the end of each case?

Isn't is safer to have a break at the end of each case?

1:46 pm

Dara Navaei

1:46 pm

Dara Navaei

UI-BUG-S62
UI-BUG-S62
Wednesday 05 Jan 2022
11:45 am

Behrouz NematiPour

Monday 03 Jan 2022
1:57 pm

Dara Navaei

1:57 pm

Dara Navaei

In the firmware we add a TODO to be able to grep them easily and make sure we do not forget any commented code. RESOLVED.

In the firmware we add a TODO to be able to grep them easily and make sure we do not forget any commented code.
RESOLVED.

1:56 pm

Dara Navaei

RESOLVED.

RESOLVED.

1:55 pm

Dara Navaei

RESOLVED.

RESOLVED.

1:55 pm

Dara Navaei

Sorry I meant parameters not arguments.

Sorry I meant parameters not arguments.

1:54 pm

Dara Navaei

RESOLVED.

RESOLVED.

12:37 pm

Behrouz NematiPour

Thursday 30 Dec 2021
9:37 am

Sean Nash

9:36 am

Sean Nash

RESOLVED.

RESOLVED.

Wednesday 22 Dec 2021
12:57 pm

Michael Garthwaite

12:57 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

Thank you!

Thank you!

11:25 am

Behrouz NematiPour

A very important concept. I refer you to the Qt connection concept for detailed information. https://doc.qt.io/qt-5/signalsandslots.html The idea is, the connect has 4 parameter 1 - Signal owner ob...

A very important concept.
I refer you to the Qt connection concept for detailed information.
https://doc.qt.io/qt-5/signalsandslots.html
The idea is, the connect has 4 parameter
1 - Signal owner object
2 - Signal member function
3 - Slot owner object
4 - Slot member function
When the signal owner is emit-ed, the slot owner will call its slot by the passed parameter from the signal function.
It is very important to use the connection concept, in opposed to the simple call, in case the signal owner and slot owner, objects, are in two different threads.
It is the Qt way of thread-safe calling.

11:11 am

Behrouz NematiPour

Ummm, Haven't ever thought about it, this is a very good point. Will look into it, since the actual friend class will not ever be available in the production code.

Ummm,
Haven't ever thought about it, this is a very good point.
Will look into it, since the actual friend class will not ever be available in the production code.

11:09 am

Behrouz NematiPour

if the parameter is not used, the name will not be specified so the compiler won't complain about the parameter not being used. Note the difference between parameters and arguments: *Function pa...

if the parameter is not used, the name will not be specified so the compiler won't complain about the parameter not being used.

Note the difference between parameters and arguments:

  • Function parameters are the names listed in the function's definition.
  • Function arguments are the real values passed to the function.
11:06 am

Behrouz NematiPour

The vScript parameter will accept the arguments which will be changed in the function, so has been defined as a reference with no const.

The vScript parameter will accept the arguments which will be changed in the function, so has been defined as a reference with no const.

10:59 am

Behrouz NematiPour

it has been fixed on the merge conflict. 748e088be863e08a1f8d12ff895c2525cd891e31

it has been fixed on the merge conflict.
748e088be863e08a1f8d12ff895c2525cd891e31

Tuesday 21 Dec 2021
2:35 pm

Dara Navaei

Why is vScript not a const?

Why is vScript not a const?

2:32 pm

Dara Navaei

Why does not this function have an argument name?

Why does not this function have an argument name?

2:21 pm

Dara Navaei

I understand that the friend classes are for dev testing, are we planning to disable them later during the release?

I understand that the friend classes are for dev testing, are we planning to disable them later during the release?