application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Aug 2022
9:50 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8500]

- Removed

0x8500 133 0x070 1 Hz N DG UI DG Chem Disinfect Time [each sub state] (U32) Timeout (secs) (0=no time estimate) (U32) Timeout countdown (secs)

Options
    • -2
    • +0
    /denali.pro
    • -1
    • +0
    /sources/canbus/MessageGlobals.h
    • -3
    • +0
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +0
    /sources/gui/GuiGlobals.h
    • -10
    • +0
    /sources/model/MModel.h
    • -45
    • +0
    /sources/model/dg/data/disinfect/MDisinfectDGChemicalTimeData.cpp
    • -82
    • +0
    /sources/model/dg/data/disinfect/MDisinfectDGChemicalTimeData.h
9:41 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8400]

- Removed

0x8400 132 0x070 1 Hz N DG UI DG Heat Disinfect Time [each sub state] (U32) Timeout (secs) (0=no time estimate) (U32) Timeout countdown (secs)

Options
    • -2
    • +0
    /denali.pro
    • -1
    • +0
    /sources/canbus/MessageGlobals.h
    • -1
    • +0
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +0
    /sources/gui/GuiGlobals.h
    • -5
    • +0
    /sources/model/MModel.h
    • -45
    • +0
    /sources/model/dg/data/disinfect/MDisinfectDGHeatTimeData.cpp
    • -82
    • +0
    /sources/model/dg/data/disinfect/MDisinfectDGHeatTimeData.h
9:30 pm

Behrouz NematiPour

DEN-13645: IMP: Disinfection Remove unused data messages [0x8300]

- removed the message:

|0x8300| 131| 0x070| 1 Hz| N| DG| UI| DG Flush Time [each sub state] |(U32) Timeout (secs) (0=no time estimate)| (U32) Timeout countdown (secs)|

Options
    • -4
    • +0
    /denali.pro
    • -1
    • +0
    /sources/canbus/MessageGlobals.h
    • -1
    • +0
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +0
    /sources/gui/GuiGlobals.cpp
    • -1
    • +0
    /sources/gui/GuiGlobals.h
    • -2
    • +0
    /sources/gui/qml/main.qml
    • -5
    • +0
    /sources/model/MModel.h
    • -45
    • +0
    /sources/model/dg/data/disinfect/MDisinfectDGFlushTimeData.cpp
    • -82
    • +0
    /sources/model/dg/data/disinfect/MDisinfectDGFlushTimeData.h
    • -1
    • +0
    /sources/view/VView.h
    • -62
    • +0
    /sources/view/dg/data/disinfect/VDisinfectDGData.cpp
    • -60
    • +0
    /sources/view/dg/data/disinfect/VDisinfectDGData.h
8:48 pm

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
8:47 pm

Behrouz NematiPour

DEN-13645: IMP: Unhandled messages duplicate keys fix

- it has been observed that the unhandled messages are not logged correctly and turned out it is because of the Types of each parameter used as keys and keys can't be duplicate by default which caused issue for the unhandled messages, since they may have 6 parameter and all with F32 type which then becomes one parameter of type F32.

- an attribute has been defined for the config file with the format:

#--duplicate_key_on

#--duplicate_key_off

to allow or disallow the duplicate key at any point in the config file.

- Note that the save config parameters are always unique key like AlarmVolume which doesn't make sense to have duplicate entry.

Options
    • -4
    • +4
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/gui/qml/pages/disinfect/DisinfectStack.qml
    • -5
    • +5
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -6
    • +11
    /sources/model/settings/MSettings.cpp
    • -1
    • +1
    /sources/model/settings/MSettings.h
    • -10
    • +40
    /sources/storage/Settings.cpp
    • -2
    • +5
    /sources/storage/Settings.h
    • -0
    • +2
    /sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.h
1:10 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -5
    • +5
    /sources/model/hd/alarm/MAlarmMapping.cpp
2:42 am

Behrouz NematiPour

DEN-13645: IMP: DEN-9297: Disinfection messaging flow review

- Disinfection current code/design review

- Disinfection Screens and Navigation implementation

- There are functions and properties used but not implemented yet in vDisinfectAdjustDisinfect, and some that are implemented are not implemented with the new design.

Options
    • -2
    • +2
    /denali.pro.user
    • -1
    • +1
    /sources/gui/GuiController.cpp
    • -0
    • +3
    /sources/gui/qml/main.qml
    • -6
    • +0
    /sources/gui/qml/pages/MainStack.qml
    • -146
    • +31
    /sources/gui/qml/pages/disinfect/DisinfectStack.qml
    • -13
    • +9
    /sources/gui/qml/pages/settings/SettingsDG.qml
    • -0
    • +1
    /sources/gui/qml/pages/settings/SettingsStack.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Friday 12 Aug 2022
5:39 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation [-k, -K]

- The logic for the check-in and Ack messages reversed to be always disabled and can be enabled later if needed.

- For Integration/Unit tests the application needs to be called with these two switches otherwise tests will fail.

Options
    • -1
    • +1
    /denali.pro.user
    • -14
    • +17
    /main.cpp
    • -4
    • +4
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -2
    • +3
    /sources/main.h
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Thursday 11 Aug 2022
7:22 pm

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
7:22 pm

Behrouz NematiPour

DEN-13645: IMP: DEN-13473: HD Communication/UI Issues

***** THIS IS AN EXPERIMENT *****

- It seems like the UI could be initialized early on, even before the controllers, so when the controllers are sending messages to UI to update the screen it is initialized and available to get update.

- previously when controllers were publishing the statuses UI was not even initialized and ready to receive any signal and that seems to be the reason some part of the UI (SD-Card status) was not get updated and missed signals.

_____

- Also added NoCANBus to able to go to Service when there is no HD to confirm the state change.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +3
    /main.cpp
    • -2
    • +6
    /sources/gui/qml/main.qml
    • -8
    • +15
    /sources/gui/qml/pages/settings/SettingsStack.qml
7:10 pm

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
5:11 pm

Behrouz NematiPour

DEN-13645 IMP: DEN-12958: UI shall generate the POST fail alarm if the SD-Card not present and stop logging

__________

- Log Export

- Added the Alarm generation on the GuiController if SD-Card is not ready, or is/becomes read-only.

- AlarmGenerator

- Added the SD-Card failure alarm - ALARM_ID_UI_POST_FAILURE_SDCARD

- Added alarm clear - ALARM_ID_NO_ALARM

- Added a flag to stop logging if the SD-Card is not ready or is readonly.

- Removed pause on log clean up.

- Improved the DeviceController SD-Card, USB status detection.

- Fixed and improved the MVC connection betweein device/Application/Gui controllers.

- A CLI switch ( -S ) added to disable the feature that is disabling the log if the SD-Card doesn't exist. So if the -S switch is used while calling the denali application, the logging will NOT be disabled, if SD-Card fails.

- In the ExportButton and USBButton(eject) removed the enable logic and has to be done outside of the component. It has been done for the Settings/export and Post-Tx/Review.

- Added title and file count for each SD-Card and USB-Drive panels.

__________

- Run.sh

- Added a check for the CloudSync and if the folder doesn't exist it won't do the rest

- Kill the denali application, in case it is still running.

- Added SD-Card type as part of its detection and if it is not ext4 format it fails the test.

- Optimized the mount point detection.

__________

- NoCANBus

- added the NoCANBus to the fault and init modes to not to navigate to those if NoCANBus is true. Otherwise it conflict with navigate to the home.

- Added a log in case the NoCANBus is enabled.

__________

- Settings

- Converted the '\n' in the settings values to actual newline character.

__________

- Thread:

- Moved the QuiController in its own thread, _Gui_Thread.

__________

- Alarms

- Added an emit to update the Alarm Dialog with the latest title/message, received from Alarms.conf In case there was an alarm before even Alarm.conf is read.

Options
    • -13
    • +13
    /AlarmMapping.csv
    • -1
    • +8
    /main.cpp
    • -34
    • +42
    /scripts/run.sh
    • -0
    • +26
    /sources/AlarmGenerator.cpp
    • -0
    • +3
    /sources/AlarmGenerator.h
    • -11
    • +20
    /sources/ApplicationController.cpp
    • -0
    • +4
    /sources/ApplicationController.h
    • -0
    • +2
    /sources/Threads.cpp
    • -0
    • +1
    /sources/Threads.h
    • -61
    • +45
    /sources/device/DeviceController.cpp
    • -3
    • +0
    /sources/device/DeviceController.h
    • -7
    • +29
    /sources/gui/GuiController.cpp
    • -0
    • +4
    /sources/gui/GuiController.h
    • -20
    • +17
    /sources/gui/GuiView.cpp
    • -3
    • +4
    /sources/gui/GuiView.h
  16. … 13 more files in changeset.
9:33 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Monday 08 Aug 2022
12:36 pm

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
12:24 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-12836: Treatment Report/log export modifications

- Finalizing the log export.

Options
    • -4
    • +0
    /sources/gui/qml/components/ExportButton.qml
    • -5
    • +4
    /sources/gui/qml/components/USBButton.qml
    • -1
    • +2
    /sources/gui/qml/pages/posttreatment/PostTreatmentReview.qml
    • -30
    • +32
    /sources/gui/qml/pages/settings/SettingsExportLogs.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Sunday 07 Aug 2022
12:30 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-12836: Treatment Report/log export modifications

- Update the eject and export button status for the export service and treatment

Options
    • -1
    • +1
    /sources/gui/GuiView.cpp
    • -0
    • +2
    /sources/gui/qml/components/ExportButton.qml
    • -0
    • +2
    /sources/gui/qml/components/USBButton.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Friday 05 Aug 2022
6:11 pm

Behrouz NematiPour

13645 Improving NoCANBus DevConf

Options
    • -2
    • +18
    /sources/gui/qml/pages/MainStack.qml
8:23 am

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
8:23 am

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-12836: Treatment Report/log export modifications

- Changed to device folders.

Options
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsExportLogs.qml
2:03 am

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
2:03 am

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-12836: Treatment Report/log export modifications

Options
    • -1
    • +1
    /AlarmMapping.csv
    • -4
    • +4
    /denali.pro.user
    • -6
    • +23
    /sources/ApplicationController.cpp
    • -2
    • +4
    /sources/ApplicationController.h
    • -6
    • +20
    /sources/gui/GuiController.cpp
    • -3
    • +7
    /sources/gui/GuiController.h
    • -2
    • +28
    /sources/gui/GuiView.cpp
    • -2
    • +7
    /sources/gui/GuiView.h
    • -21
    • +144
    /sources/gui/qml/pages/settings/SettingsExportLogs.qml
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -7
    • +89
    /sources/storage/Logger.cpp
    • -3
    • +19
    /sources/storage/Logger.h
Wednesday 03 Aug 2022
11:11 pm

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
11:10 pm

Behrouz NematiPour

DEN-13645: IMP: General Implementation

DEN-13447: UI able to send its final POST result to HD by request

Options
    • -0
    • +2
    /denali.pro
    • -24
    • +24
    /denali.pro.user
    • -0
    • +5
    /sources/ApplicationController.h
    • -0
    • +3
    /sources/canbus/MessageDispatcher.h
    • -0
    • +1
    /sources/canbus/MessageGlobals.h
    • -0
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +3
    /sources/gui/GuiController.h
    • -1
    • +2
    /sources/gui/GuiGlobals.h
    • -0
    • +9
    /sources/main.h
    • -2
    • +8
    /sources/model/MModel.h
    • -0
    • +38
    /sources/model/hd/data/post/MUIPostFinalResultHDRequest.cpp
    • -0
    • +78
    /sources/model/hd/data/post/MUIPostFinalResultHDRequest.h
3:40 am

Behrouz NematiPour

DEN-13488 SCA: Code Analysis

Options
    • -9
    • +9
    /cppcheck.err
    • -0
    • +1
    /cppcheck.log
3:18 am

Behrouz NematiPour

Merge branch 'DEN-13198-UI_BN_75' into develop

Options
2:59 am

Behrouz NematiPour

DEN-13489 IMP: General Implementation

DEN-13035: Update alarm body messages

- Removed the exclamation mark icon form the Alarm Dialog.

- Removed the exclamation mark icon form the Alarm Bar.

- Made the whole AlarmDialog title bar doubleClick and diagnostics opener if the alarm is not minimizable.

- Moved the Alarm ID from title to the bottom left of the dialog with format: "ID:<id>".

- Clipped the AlarmDialon body message area, crop the text if longer than dialog area.

- Changed the "settings" property name of the VSettings to "instructions".

- Changed the date/time formats keys to simplify the code and conf file.

- Implemented the Alarm Body messages, to load from Alams/Alarms.conf, instead of the FW.

- The FW texts/documents will still being used if the Alarms.conf doesn't have a definition.

- A instruction base capability has also been added to the MVC, but UI still not supporting it.

Options
    • -3
    • +3
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -3
    • +3
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/cloudsync/CloudSyncController.cpp
    • -8
    • +9
    /sources/gui/qml/AlarmItem.qml
    • -9
    • +9
    /sources/gui/qml/components/NotificationBar.qml
    • -18
    • +27
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -4
    • +3
    /sources/gui/qml/main.qml
    • -8
    • +6
    /sources/gui/qml/pages/TreatmentFlowBase.qml
    • -3
    • +3
    /sources/gui/qml/pages/settings/SettingsDG.qml
    • -293
    • +293
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -2
    • +2
    /sources/model/settings/MSettings.cpp
    • -0
    • +25
    /sources/storage/Settings.h
    • -0
    • +7
    /sources/storage/StorageGlobals.cpp
    • -0
    • +6
    /sources/storage/StorageGlobals.h
  16. … 4 more files in changeset.
2:37 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Tuesday 02 Aug 2022
5:04 pm

Tiffany Mejia

updates model unit tests

Options
    • -791
    • +2572
    /unittests/tst_models.cpp
    • -48
    • +89
    /unittests/tst_models.h
Monday 01 Aug 2022
1:43 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -293
    • +293
    /sources/model/hd/alarm/MAlarmMapping.cpp
Thursday 28 Jul 2022
10:49 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp