firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3259 imported the code changes from LEAH-1415

    • -0
    • +72
    ./.settings/org.eclipse.cdt.codan.core.prefs
    • -0
    • +13
    ./.settings/org.eclipse.core.resources.prefs
    • -0
    • +122
    ./App/Modes/OperationModes.c
    • -0
    • +25
    ./App/Modes/OperationModes.h
    • -0
    • +68
    ./App/Services/Comm.c
  1. … 39 more files in changeset.
LEAHI-BOOTLOADER-LDT-3259_Software Update - TD
LEAHI-BOOTLOADER-LDT-3259_Software Update - TD
LEAH-1415 updated the bootloader code to be more comaptible with Leahi

TODO

TODO

TODO

TODO

TODO should be all caps.

TODO should be all caps.

TODO should be all caps for consistency (so we know what to search for).

TODO should be all caps for consistency (so we know what to search for).

I think it should be restored even if it's not used anywhere yet.

I think it should be restored even if it's not used anywhere yet.

Do we need an end of group marker down here?

Do we need an end of group marker down here?

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

LEAH-1415 addressed the code review comments

It will be implemented in the new branch.

It will be implemented in the new branch.

Done

Done

Done

Done

Done

Done

Done

Done

Removed the variable.

Removed the variable.

Removed the TODO.

Removed the TODO.

Removed the interrupt.

Removed the interrupt.

Done

Done

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

Added the return of a value.

Added the return of a value.

Done

Done

Done

Done

Added the return.

Added the return.

Done

Done

I will implement the watchdog in the new branch.

I will implement the watchdog in the new branch.

I will implement the watchdog in the new branch.

I will implement the watchdog in the new branch.