common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-6080 added comments and new alarm IDs

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Start comment with capital letter for consistency with the other lines.

Start comment with capital letter for consistency with the other lines.

Start comment with capital letter for consistency with the other lines.

Start comment with capital letter for consistency with the other lines.

Done

Done

Add new alarms to the below alarm table.

Add new alarms to the below alarm table.

Need comments for Doxygen.

Need comments for Doxygen.

Any time we're pulling the safety line, there should be a fault triggered as well - otherwise s/w will be expecting things to continue operating normally and, of course, with safety line pulled the...

Any time we're pulling the safety line, there should be a fault triggered as well - otherwise s/w will be expecting things to continue operating normally and, of course, with safety line pulled they won't - causing a potential slew of alarms that won't make sense.

Done

Done

Assume this is 10% (not 0.1%), so not technically a percent.

Assume this is 10% (not 0.1%), so not technically a percent.

I don't see alarm ID split in this review (AlarmDefs.h). Add common repositories to this review.

I don't see alarm ID split in this review (AlarmDefs.h). Add common repositories to this review.

Suggest using a local variable to store target drain pump RPM value to avoid calling the same function twice.

Suggest using a local variable to store target drain pump RPM value to avoid calling the same function twice.

Use parentheses to separate conditions.

Use parentheses to separate conditions.

DG-DEN-5963_DG Heat Disinfect (2 of 2)
DG-DEN-5963_DG Heat Disinfect (2 of 2)
DG-DEN-6080_Revisit DG Drain Pump Control Scheme
DG-DEN-6080_Revisit DG Drain Pump Control Scheme
DEN-6081 added another alarm ID for flow rate out of lower range

quick_fix_01

- changed the enum index to 49 to be like the previous so the test won't fail.

quick_fix_01

- During the headless SquishQt test found out that a change on the common repo made the build failed.

- The modification was deletion of ALARM_ID_TEMPERATURE_SENSORS_INCONSISTENT enum item.

It has been reverted back to make the build work with application master branch but checking out to this branch for the use of common codes.

Merge branch 'Sprint33' into develop

DEN-5674: Added msg ID for auto-ACK to enum. Updated some alarm properties in alarm table.

DEN-5674: Fixed alignment of alarms table header.

It is at the beginning of Prime sub-mode.

It is at the beginning of Prime sub-mode.

Where did command to start reservoir 2 as active get moved to?

Where did command to start reservoir 2 as active get moved to?

Merge branch 'Sprint33' into develop

DEN-5381: Added reservoir one fill complete state for prime sub-mode