common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 Dec 2020
10:25 am

Dara Navaei

DEN-6080 added comments and new alarm IDs

Options
    • -0
    • +3
    /AlarmDefs.h
    • -17
    • +17
    /DGDefs.h
10:22 am

Dara Navaei

Done

Done

10:22 am

Dara Navaei

Done

Done

10:21 am

Dara Navaei

Done

Done

10:20 am

Dara Navaei

Done

Done

10:17 am

Dara Navaei

Done

Done

10:16 am

Dara Navaei

Done

Done

10:15 am

pmontazemi  (deleted user)

Start comment with capital letter for consistency with the other lines.

Start comment with capital letter for consistency with the other lines.

10:15 am

pmontazemi  (deleted user)

Start comment with capital letter for consistency with the other lines.

Start comment with capital letter for consistency with the other lines.

10:13 am

Dara Navaei

Done

Done

9:19 am

qnguyen  (deleted user)

Add new alarms to the below alarm table.

Add new alarms to the below alarm table.

9:17 am

Sean Nash

Need comments for Doxygen.

Need comments for Doxygen.

9:12 am

Sean Nash

Any time we're pulling the safety line, there should be a fault triggered as well - otherwise s/w will be expecting things to continue operating normally and, of course, with safety line pulled the...

Any time we're pulling the safety line, there should be a fault triggered as well - otherwise s/w will be expecting things to continue operating normally and, of course, with safety line pulled they won't - causing a potential slew of alarms that won't make sense.

9:09 am

Dara Navaei

Done

Done

8:41 am

Sean Nash

Assume this is 10% (not 0.1%), so not technically a percent.

Assume this is 10% (not 0.1%), so not technically a percent.

8:38 am

Sean Nash

I don't see alarm ID split in this review (AlarmDefs.h). Add common repositories to this review.

I don't see alarm ID split in this review (AlarmDefs.h). Add common repositories to this review.

Monday 28 Dec 2020
8:27 pm

qnguyen  (deleted user)

Suggest using a local variable to store target drain pump RPM value to avoid calling the same function twice.

Suggest using a local variable to store target drain pump RPM value to avoid calling the same function twice.

8:25 pm

qnguyen  (deleted user)

Use parentheses to separate conditions.

Use parentheses to separate conditions.

1:02 pm

Dara Navaei

DG-DEN-5963_DG Heat Disinfect (2 of 2)
DG-DEN-5963_DG Heat Disinfect (2 of 2)
1:02 pm

Dara Navaei

DG-DEN-6080_Revisit DG Drain Pump Control Scheme
DG-DEN-6080_Revisit DG Drain Pump Control Scheme
10:46 am

Dara Navaei

DEN-6081 added another alarm ID for flow rate out of lower range

Options
    • -1
    • +4
    /AlarmDefs.h
    • -7
    • +17
    /DGDefs.h
Monday 21 Dec 2020
2:06 pm

Behrouz NematiPour

quick_fix_01

- changed the enum index to 49 to be like the previous so the test won't fail.

Options
    • -1
    • +1
    /AlarmDefs.h
12:12 pm

Behrouz NematiPour

quick_fix_01

- During the headless SquishQt test found out that a change on the common repo made the build failed.

- The modification was deletion of ALARM_ID_TEMPERATURE_SENSORS_INCONSISTENT enum item.

It has been reverted back to make the build work with application master branch but checking out to this branch for the use of common codes.

Options
    • -16
    • +20
    /AlarmDefs.h
Friday 18 Dec 2020
3:47 pm

Sean Nash

Merge branch 'Sprint33' into develop

Options
3:47 pm

Sean Nash

DEN-5674: Added msg ID for auto-ACK to enum. Updated some alarm properties in alarm table.

Options
    • -1
    • +1
    /AlarmDefs.h
    • -0
    • +2
    /MsgDefs.h
11:28 am

Sean Nash

DEN-5674: Fixed alignment of alarms table header.

Options
    • -1
    • +1
    /AlarmDefs.h
Thursday 17 Dec 2020
4:20 pm

qnguyen  (deleted user)

It is at the beginning of Prime sub-mode.

It is at the beginning of Prime sub-mode.

4:17 pm

Sean Nash

Where did command to start reservoir 2 as active get moved to?

Where did command to start reservoir 2 as active get moved to?

4:05 pm

Sean Nash

Merge branch 'Sprint33' into develop

Options
1:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-5381: Added reservoir one fill complete state for prime sub-mode

Options
    • -0
    • +1
    /HDDefs.h