common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 16 Jan 2021
12:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added prime out of time alarm and command reject reasons

Options
    • -0
    • +2
    /AlarmDefs.h
    • -1
    • +1
    /DGDefs.h
    • -1
    • +12
    /MsgDefs.h
12:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added prime out of time alarm and command reject reasons

Options
    • -0
    • +2
    /AlarmDefs.h
    • -1
    • +1
    /DGDefs.h
    • -1
    • +12
    /MsgDefs.h
Friday 15 Jan 2021
9:32 pm

qnguyen  (deleted user)

Removed alarm clear action.

Removed alarm clear action.

9:31 pm

qnguyen  (deleted user)

Done.

Done.

9:31 pm

qnguyen  (deleted user)

Done.

Done.

9:31 pm

qnguyen  (deleted user)

Done.

Done.

9:30 pm

qnguyen  (deleted user)

Done.

Done.

9:27 pm

qnguyen  (deleted user)

Added priming time countdown and priming current state.

Added priming time countdown and priming current state.

3:23 pm

qnguyen  (deleted user)

Moved reservoir switching to prime state machine.

Moved reservoir switching to prime state machine.

3:15 pm

qnguyen  (deleted user)

Changed drain volume to 0.

Changed drain volume to 0.

3:14 pm

qnguyen  (deleted user)

Added TODO.

Added TODO.

3:03 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

3:02 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

3:02 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

3:02 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

11:47 am

qnguyen  (deleted user)

Combined getAlarmId and isAlarmActive functions.

Combined getAlarmId and isAlarmActive functions.

11:39 am

Sean Nash

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

11:34 am

qnguyen  (deleted user)

Extra spaces is to keep all the variables align. Removed extra space below to keep alignment.

Extra spaces is to keep all the variables align.
Removed extra space below to keep alignment.

11:33 am

qnguyen  (deleted user)

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

11:29 am

qnguyen  (deleted user)

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

11:25 am

pmontazemi  (deleted user)

Why and where were these persistent alarm moved to?

Why and where were these persistent alarm moved to?

11:24 am

pmontazemi  (deleted user)

Remove extra spaces before = sign.

Remove extra spaces before = sign.

11:10 am

Sean Nash

Do we need to wait until we're done with first part of dialysate prime (or at least check to make sure it's already done) before we switch reservoirs?

Do we need to wait until we're done with first part of dialysate prime (or at least check to make sure it's already done) before we switch reservoirs?

11:05 am

Sean Nash

Is half fill appropriate for both reservoirs? I think we need a TODO here to determine the fill volume we want for each reservoir and I believe they will be different in the end so we probably need...

Is half fill appropriate for both reservoirs? I think we need a TODO here to determine the fill volume we want for each reservoir and I believe they will be different in the end so we probably need two #defines here.

11:00 am

Sean Nash

What if DG does not go to drain mode (e.g. DG rejected drain command)? We will get stuck in this state. Let's discuss DG command handling - we may need to add more to DG response so HD can handle t...

What if DG does not go to drain mode (e.g. DG rejected drain command)? We will get stuck in this state. Let's discuss DG command handling - we may need to add more to DG response so HD can handle these types of issues.

10:54 am

Sean Nash

I think we want to be broadcasting priming progress (% complete or maybe est. time (in secs) countdown) during prime (really prime+wet self-tests) so UI can show progress. Peter may have already de...

I think we want to be broadcasting priming progress (% complete or maybe est. time (in secs) countdown) during prime (really prime+wet self-tests) so UI can show progress. Peter may have already defined a msg for this. Consider what else may need to be broadcast during prime for Dialin purposes.

10:48 am

Sean Nash

I know, but the clearing occurs before the mode gets this signal (see signalAlarmUserActionInitiated() in AlarmMgmt.c). So you don't need to clear it again here.

I know, but the clearing occurs before the mode gets this signal (see signalAlarmUserActionInitiated() in AlarmMgmt.c). So you don't need to clear it again here.

10:44 am

pmontazemi  (deleted user)

Where is alarmIsActive[] input in the code?

Where is alarmIsActive[] input in the code?

10:39 am

qnguyen  (deleted user)

Done.

Done.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.