common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-6200: Added clarification to command request rejection

DEN-6200: Added clarification to command request rejection

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

What parameter is invalid?

What parameter is invalid?

One msg for all DG commands? How will HD know which command is being responded to?

One msg for all DG commands? How will HD know which command is being responded to?

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading...

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading cartridge/disposables). So some signals can be handled here and others will need to be forwarded to the current sub-mode where more context can be assessed.

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

Are these for HD to DG commands? Clarify in comment, name.

Are these for HD to DG commands? Clarify in comment, name.

DEN-6200: Added prime out of time alarm and command reject reasons

DEN-6200: Added prime out of time alarm and command reject reasons

Removed alarm clear action.

Removed alarm clear action.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Added priming time countdown and priming current state.

Added priming time countdown and priming current state.

Moved reservoir switching to prime state machine.

Moved reservoir switching to prime state machine.

Changed drain volume to 0.

Changed drain volume to 0.

Added TODO.

Added TODO.

Add extra line.

Add extra line.

Add extra line.

Add extra line.

Add extra line.

Add extra line.

Add extra line.

Add extra line.

Combined getAlarmId and isAlarmActive functions.

Combined getAlarmId and isAlarmActive functions.

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

Extra spaces is to keep all the variables align. Removed extra space below to keep alignment.

Extra spaces is to keep all the variables align.
Removed extra space below to keep alignment.

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

Why and where were these persistent alarm moved to?

Why and where were these persistent alarm moved to?

Remove extra spaces before = sign.

Remove extra spaces before = sign.