common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Jan 2021
10:02 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added clarification to command request rejection

Options
    • -15
    • +36
    /DGDefs.h
    • -1
    • +1
    /HDDefs.h
    • -5
    • +5
    /MsgDefs.h
10:02 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added clarification to command request rejection

Options
    • -15
    • +36
    /DGDefs.h
    • -1
    • +1
    /HDDefs.h
    • -5
    • +5
    /MsgDefs.h
10:00 am

Sean Nash

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

9:56 am

Sean Nash

What parameter is invalid?

What parameter is invalid?

9:49 am

Sean Nash

One msg for all DG commands? How will HD know which command is being responded to?

One msg for all DG commands? How will HD know which command is being responded to?

9:45 am

Sean Nash

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading...

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading cartridge/disposables). So some signals can be handled here and others will need to be forwarded to the current sub-mode where more context can be assessed.

9:40 am

Sean Nash

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

9:36 am

Sean Nash

Are these for HD to DG commands? Clarify in comment, name.

Are these for HD to DG commands? Clarify in comment, name.

Saturday 16 Jan 2021
12:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added prime out of time alarm and command reject reasons

Options
    • -0
    • +2
    /AlarmDefs.h
    • -1
    • +1
    /DGDefs.h
    • -1
    • +12
    /MsgDefs.h
12:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added prime out of time alarm and command reject reasons

Options
    • -0
    • +2
    /AlarmDefs.h
    • -1
    • +1
    /DGDefs.h
    • -1
    • +12
    /MsgDefs.h
Friday 15 Jan 2021
9:32 pm

qnguyen  (deleted user)

Removed alarm clear action.

Removed alarm clear action.

9:31 pm

qnguyen  (deleted user)

Done.

Done.

9:31 pm

qnguyen  (deleted user)

Done.

Done.

9:31 pm

qnguyen  (deleted user)

Done.

Done.

9:30 pm

qnguyen  (deleted user)

Done.

Done.

9:27 pm

qnguyen  (deleted user)

Added priming time countdown and priming current state.

Added priming time countdown and priming current state.

3:23 pm

qnguyen  (deleted user)

Moved reservoir switching to prime state machine.

Moved reservoir switching to prime state machine.

3:15 pm

qnguyen  (deleted user)

Changed drain volume to 0.

Changed drain volume to 0.

3:14 pm

qnguyen  (deleted user)

Added TODO.

Added TODO.

3:03 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

3:02 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

3:02 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

3:02 pm

pmontazemi  (deleted user)

Add extra line.

Add extra line.

11:47 am

qnguyen  (deleted user)

Combined getAlarmId and isAlarmActive functions.

Combined getAlarmId and isAlarmActive functions.

11:39 am

Sean Nash

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

I understand that prime will likely finish its job before the reservoir fills, but what if it doesn't? If fill finishes first, this code will switch reservoirs before prime was done using it.

11:34 am

qnguyen  (deleted user)

Extra spaces is to keep all the variables align. Removed extra space below to keep alignment.

Extra spaces is to keep all the variables align.
Removed extra space below to keep alignment.

11:33 am

qnguyen  (deleted user)

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

11:29 am

qnguyen  (deleted user)

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

11:25 am

pmontazemi  (deleted user)

Why and where were these persistent alarm moved to?

Why and where were these persistent alarm moved to?

11:24 am

pmontazemi  (deleted user)

Remove extra spaces before = sign.

Remove extra spaces before = sign.