common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Jan 2021
5:16 pm

Sean Nash

DEN-6372: Updated rinseback and re-circ sub-modes in enum. Added new rinseback and re-circ message IDs.

Options
    • -0
    • +4
    /MsgDefs.h
5:16 pm

Sean Nash

DEN-6372: Updated rinseback and re-circ sub-modes in enum. Added new rinseback and re-circ message IDs.

Options
    • -1
    • +1
    /AlarmDefs.h
    • -4
    • +36
    /HDDefs.h
    • -0
    • +4
    /MsgDefs.h
5:03 pm

Sean Nash

DEN-6372: Updated rinseback and re-circulate sub-modes in enum.

Options
    • -1
    • +1
    /AlarmDefs.h
    • -4
    • +36
    /HDDefs.h
2:38 pm

qnguyen  (deleted user)

Pretreatment mode does not have data needed to be broadcast. We might have more data once the mode is more mature.

Pretreatment mode does not have data needed to be broadcast.
We might have more data once the mode is more mature.

2:05 pm

qnguyen  (deleted user)

Fixed. This signal indicates the start of treatment.

Fixed. This signal indicates the start of treatment.

2:03 pm

qnguyen  (deleted user)

Added clarification to comment and name.

Added clarification to comment and name.

2:01 pm

qnguyen  (deleted user)

The message has a command id field.

The message has a command id field.

1:58 pm

qnguyen  (deleted user)

Added command id to command response.

Added command id to command response.

1:56 pm

qnguyen  (deleted user)

The dialysate temperature HD sent to DG as another message.

The dialysate temperature HD sent to DG as another message.

10:42 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:42 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added clarification to command request rejection

Options
    • -15
    • +36
    /DGDefs.h
    • -1
    • +1
    /HDDefs.h
    • -5
    • +5
    /MsgDefs.h
10:02 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Added clarification to command request rejection

Options
    • -15
    • +36
    /DGDefs.h
    • -1
    • +1
    /HDDefs.h
    • -5
    • +5
    /MsgDefs.h
10:00 am

Sean Nash

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

If we are using a single message to respond to multiple commands, should we include a parameter indicating which command we are responding to?

9:56 am

Sean Nash

What parameter is invalid?

What parameter is invalid?

9:49 am

Sean Nash

One msg for all DG commands? How will HD know which command is being responded to?

One msg for all DG commands? How will HD know which command is being responded to?

9:45 am

Sean Nash

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading...

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading cartridge/disposables). So some signals can be handled here and others will need to be forwarded to the current sub-mode where more context can be assessed.

9:40 am

Sean Nash

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

9:36 am

Sean Nash

Are these for HD to DG commands? Clarify in comment, name.

Are these for HD to DG commands? Clarify in comment, name.