common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Feb 2021
9:53 am

Sean Nash

Merge branch 'Sprint37' of ssh://dvm-linux02:7999/comm/common into Sprint37

Options
    • -0
    • +3
    /MsgDefs.h
9:53 am

Sean Nash

DEN-6372: Added treatment re-circ status message to UI.

Options
    • -0
    • +1
    /MsgDefs.h
9:17 am

qnguyen  (deleted user)

Tuesday 09 Feb 2021
7:26 pm

qnguyen  (deleted user)

Done.

Done.

7:26 pm

qnguyen  (deleted user)

Done.

Done.

7:25 pm

qnguyen  (deleted user)

Done.

Done.

7:25 pm

qnguyen  (deleted user)

Removed this sub-mode.

Removed this sub-mode.

7:25 pm

qnguyen  (deleted user)

Removed the sub-mode. Each sub-mode will have their pause/stopped state.

Removed the sub-mode. Each sub-mode will have their pause/stopped state.

7:23 pm

qnguyen  (deleted user)

Removed. Door close has been converted to sub-mode state for appropriate sub-mode (no cartridge self-test, dry self-test)

Removed. Door close has been converted to sub-mode state for appropriate sub-mode (no cartridge self-test, dry self-test)

7:22 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'Sprint37' into develop

Options
7:22 pm

Quang Nguyen <qnguyen@diality.com>

DEN-6402: Removed unused sub-mode and added new alarms

Options
    • -2
    • +6
    /AlarmDefs.h
    • -3
    • +1
    /HDDefs.h
7:14 pm

qnguyen  (deleted user)

Removed. Pause state should be handled by sub-mode.

Removed. Pause state should be handled by sub-mode.

7:14 pm

qnguyen  (deleted user)

Removed. This has been converted to pre-treatment recirculate sub-mode state.

Removed. This has been converted to pre-treatment recirculate sub-mode state.

7:12 pm

qnguyen  (deleted user)

This will be done once we get to patient connection sub-mode. Added TODO.

This will be done once we get to patient connection sub-mode. Added TODO.

7:11 pm

qnguyen  (deleted user)

Fixed. Now store command response for each possible commands rather than one command response for all commands.

Fixed. Now store command response for each possible commands rather than one command response for all commands.

7:07 pm

qnguyen  (deleted user)

It will persist unless HD issues another command to DG.

It will persist unless HD issues another command to DG.

12:30 pm

Dara Navaei

DEN-5980 added messages ID for calibration set/send/get

Options
    • -0
    • +1
    /DGDefs.h
    • -0
    • +3
    /MsgDefs.h
11:02 am

Sean Nash

Merge branch 'Sprint37' into develop

Options
11:01 am

Sean Nash

DEN-6372: Updated alarm table properties.

Options
    • -116
    • +120
    /AlarmDefs.h
Monday 08 Feb 2021
8:13 pm

Sean Nash

DEN-6372: Added alarm property that can prevent dialysate re-circulation while that alarm is active.

Options
    • -137
    • +143
    /AlarmDefs.h
2:42 pm

Sean Nash

DEN-6372: Added treatment stop states enum.

Options
    • -0
    • +17
    /HDDefs.h
12:02 pm

qnguyen  (deleted user)

Corrected.

Corrected.

11:42 am

qnguyen  (deleted user)

Done.

Done.

11:19 am

qnguyen  (deleted user)

Done.

Done.

11:06 am

qnguyen  (deleted user)

Done.

Done.

9:51 am

Sean Nash

If not yet in fill mode, will dgCmdResp persist to next time?

If not yet in fill mode, will dgCmdResp persist to next time?

9:50 am

Sean Nash

Is this response persistent? Or does this function consume the response? Even if persistent, I suspect a new response will replace previous response and this makes me nervous. I think it would be s...

Is this response persistent? Or does this function consume the response? Even if persistent, I suspect a new response will replace previous response and this makes me nervous. I think it would be safer to have a separate flag for each possible response so there is no race condition.

9:46 am

Sean Nash

This flag does not appear to be a "result". Rename to primeCompleted.

This flag does not appear to be a "result". Rename to primeCompleted.

9:43 am

Sean Nash

This is now included in the header file so we can remove here.

This is now included in the header file so we can remove here.

9:29 am

Sean Nash

This function is too big. Create static functions to handle these switch cases.

This function is too big. Create static functions to handle these switch cases.