common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Feb 2021
9:37 am

Sean Nash

The current design is for each mode to set actuators on entry to a new mode/sub-mode (e.g. this function) per that mode's initial state. Then, while in that mode/sub-mode, the mode's state machine ...

The current design is for each mode to set actuators on entry to a new mode/sub-mode (e.g. this function) per that mode's initial state. Then, while in that mode/sub-mode, the mode's state machine will change actuators as required when moving from one state to another.

9:33 am

pmontazemi  (deleted user)

This is the reason why at one of my previous companies we used to name variables with f_ or i_ as first characters to know at a glance the variable type definition. Now worth considering though.

This is the reason why at one of my previous companies we used to name variables with f_ or i_ as first characters to know at a glance the variable type definition. Now worth considering though.

9:33 am

Sean Nash

Not fully clear what the sub-modes of service mode will be. At this time, I don't know what, if anything, should happen if the user presses the stop/pause button while in service mode. For now, the...

Not fully clear what the sub-modes of service mode will be. At this time, I don't know what, if anything, should happen if the user presses the stop/pause button while in service mode. For now, there is nothing to stop so we are ignoring.

9:32 am

Dara Navaei

Do we need a #define 0.8?

Do we need a #define 0.8?

9:32 am

Dara Navaei

Do we need a #define for 1.2?

Do we need a #define for 1.2?

9:30 am

Sean Nash

Removed.

Removed.

9:28 am

pmontazemi  (deleted user)

Delete or add TODO comment.

Delete or add TODO comment.

9:20 am

pmontazemi  (deleted user)

Is the stop button still part of the design? And why are we ignoring it here?

Is the stop button still part of the design? And why are we ignoring it here?

9:19 am

pmontazemi  (deleted user)

Replace with function that sets these valves. Settings valves can be its own module for the various modes/sates and sub-modes/sub-states. This same concept can be applied to all actuators where in ...

Replace with function that sets these valves. Settings valves can be its own module for the various modes/sates and sub-modes/sub-states. This same concept can be applied to all actuators where in mode/sate or sub-mode/sub-state, the valves, the pumps, etc. are all set. I would like to avoid setting just the valves manually here and again manually set somewhere else. Let's keep all states centralized per mode/sub-mode or state/sub-state.

9:14 am

qnguyen  (deleted user)

In verify state, we change the target pressure with the average pressure over the verify period. That pressure value is in float. For RO pump publish data, the data type for target pressure is floa...

In verify state, we change the target pressure with the average pressure over the verify period. That pressure value is in float.
For RO pump publish data, the data type for target pressure is float as well.

9:14 am

pmontazemi  (deleted user)

Do both #ifndef need to be satisfied for this portion of the code to execute? Where (at what time) are these two parameters set?

Do both #ifndef need to be satisfied for this portion of the code to execute? Where (at what time) are these two parameters set?

9:12 am

Dara Navaei

For the time that the RO pump is switching between ramp and stabilize to get to the flow, the drain continues, does that affect the drain process?

For the time that the RO pump is switching between ramp and stabilize to get to the flow, the drain continues, does that affect the drain process?

9:10 am

Sean Nash

Calibration factors live in non-volatile memory. Set during calibration via Dialin.

Calibration factors live in non-volatile memory. Set during calibration via Dialin.

9:06 am

Dara Navaei

Why the RPM has been lowered?

Why the RPM has been lowered?

9:04 am

pmontazemi  (deleted user)

Where is bloodFlowCalGain defined and what is its value? Is it fixed across machines or does it get set at calibration time?

Where is bloodFlowCalGain defined and what is its value? Is it fixed across machines or does it get set at calibration time?

9:02 am

Dara Navaei

Do we need any persistent alarm after a couple of trials? How many times are you planning to go back and forth?

Do we need any persistent alarm after a couple of trials? How many times are you planning to go back and forth?

8:56 am

Dara Navaei

Are we planning to provide pressure in float? Like 30.25 psi?

Are we planning to provide pressure in float? Like 30.25 psi?

12:48 am

qnguyen  (deleted user)

12:47 am

qnguyen  (deleted user)

Agreed. Moved to DGDefs.h

Agreed. Moved to DGDefs.h

12:00 am

qnguyen  (deleted user)

Next cmdSetDGActiveReservoir will put the valves back in a normal state.

Next cmdSetDGActiveReservoir will put the valves back in a normal state.

Wednesday 10 Feb 2021
11:15 pm

Sean Nash

Should this be moved to common\DG_Defs.h? I see HD has same typedef.

Should this be moved to common\DG_Defs.h? I see HD has same typedef.

11:08 pm

Sean Nash

Do we need a setting for normal control via active reservoir? Or will the next cmdSetDGActiveReservoir command put the valves back in a normal state?

Do we need a setting for normal control via active reservoir? Or will the next cmdSetDGActiveReservoir command put the valves back in a normal state?

11:01 am

qnguyen  (deleted user)

DG-DEN-6402_HD Dev Pretreatment Self Tests
DG-DEN-6402_HD Dev Pretreatment Self Tests
9:17 am

qnguyen  (deleted user)

Tuesday 09 Feb 2021
7:26 pm

qnguyen  (deleted user)

Done.

Done.

7:26 pm

qnguyen  (deleted user)

Done.

Done.

7:25 pm

qnguyen  (deleted user)

Done.

Done.

7:25 pm

qnguyen  (deleted user)

Removed this sub-mode.

Removed this sub-mode.

7:25 pm

qnguyen  (deleted user)

Removed the sub-mode. Each sub-mode will have their pause/stopped state.

Removed the sub-mode. Each sub-mode will have their pause/stopped state.

7:23 pm

qnguyen  (deleted user)

Removed. Door close has been converted to sub-mode state for appropriate sub-mode (no cartridge self-test, dry self-test)

Removed. Door close has been converted to sub-mode state for appropriate sub-mode (no cartridge self-test, dry self-test)