common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 Feb 2021
9:26 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added sample water state, messages and user actions

Options
    • -2
    • +16
    /DGDefs.h
    • -0
    • +20
    /HDDefs.h
    • -2
    • +16
    /MsgDefs.h
Monday 22 Feb 2021
7:35 pm

qnguyen  (deleted user)

6:42 pm

qnguyen  (deleted user)

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

2:55 pm

pmontazemi  (deleted user) and Sean Nash

1:32 pm

qnguyen  (deleted user)

1:27 pm

Dara Navaei and Sean Nash

10:10 am

Sean Nash

Move "//" to left for consistency.

Move "//" to left for consistency.

10:09 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

10:09 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

10:08 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:08 am

Sean Nash

Consider creating a structure for the 3 U32s to reduce memcpys.

Consider creating a structure for the 3 U32s to reduce memcpys.

10:06 am

Sean Nash

Delete this function. Obsolete.

Delete this function. Obsolete.

10:06 am

Sean Nash

Delete this function. Obsolete.

Delete this function. Obsolete.

10:05 am

Sean Nash

Delete this function. Obsolete.

Delete this function. Obsolete.

10:04 am

Sean Nash

Delete this case. Obsolete.

Delete this case. Obsolete.

10:02 am

Sean Nash

Remove "_DIALYSIS" and it should compile. Do this throughout.

Remove "_DIALYSIS" and it should compile. Do this throughout.

10:01 am

Sean Nash

Just delete this case. Obsolete.

Just delete this case. Obsolete.

10:01 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:00 am

Sean Nash

Leave this as is and just don't define SKIP_POST build switch if you want your POST to run.

Leave this as is and just don't define SKIP_POST build switch if you want your POST to run.

9:59 am

Sean Nash

Why are these commented out?

Why are these commented out?

9:57 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:54 am

Sean Nash

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

9:48 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:47 am

Sean Nash

You can remove the else - no longer needed.

You can remove the else - no longer needed.

9:46 am

Sean Nash

These cases should be in same order as enum. POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So shou...

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?

9:41 am

Sean Nash

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

9:40 am

Sean Nash

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

9:36 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

9:34 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

9:34 am

Sean Nash

Position may be ok. Check dependencies though.

Position may be ok. Check dependencies though.