common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
1. How are we syncing times between UI RTC and HD RTC? 2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI...

1. How are we syncing times between UI RTC and HD RTC?
2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI APP?

Align comment.

Align comment.

Consider using TREATMENT_STATE_DATA_T data structure.

Consider using TREATMENT_STATE_DATA_T data structure.

HD-DEN-7091_Pre Treatment Mode
HD-DEN-7091_Pre Treatment Mode
DG-DEN-7091_Pre Treatment Mode
DG-DEN-7091_Pre Treatment Mode
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Timeout is not in ms. Renamed constant.

Timeout is not in ms. Renamed constant.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Move "//" to left for consistency.

Move "//" to left for consistency.

Why are all of these commented out?

Why are all of these commented out?

Why are all of these commented out?

Why are all of these commented out?

Why is this commented out?

Why is this commented out?

Consider creating a structure for the 3 U32s to reduce memcpys.

Consider creating a structure for the 3 U32s to reduce memcpys.

Delete this function. Obsolete.

Delete this function. Obsolete.

Delete this function. Obsolete.

Delete this function. Obsolete.

Delete this function. Obsolete.

Delete this function. Obsolete.

Delete this case. Obsolete.

Delete this case. Obsolete.

Remove "_DIALYSIS" and it should compile. Do this throughout.

Remove "_DIALYSIS" and it should compile. Do this throughout.

Just delete this case. Obsolete.

Just delete this case. Obsolete.

Why is this commented out?

Why is this commented out?

Leave this as is and just don't define SKIP_POST build switch if you want your POST to run.

Leave this as is and just don't define SKIP_POST build switch if you want your POST to run.

Why are these commented out?

Why are these commented out?

Why is this commented out?

Why is this commented out?

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Why is this commented out?

Why is this commented out?

You can remove the else - no longer needed.

You can remove the else - no longer needed.