common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Did you add a call to this function in PriorityTask.c?

Did you add a call to this function in PriorityTask.c?

I don't think you need ModeTreatmentParams.h or OperationModes.h.

I don't think you need ModeTreatmentParams.h or OperationModes.h.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Also mention return value in @return of header.

Also mention return value in @return of header.

Addressed.

Addressed.

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

I expected to see a couple new cases here for handling override commands.

I expected to see a couple new cases here for handling override commands.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Addressed.

Addressed.

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Consider merging these two declarations.

Consider merging these two declarations.

HD-DEN-6890_Fluid Leak Detector Driver
HD-DEN-6890_Fluid Leak Detector Driver
HD-DEN-6372_HD Rinseback
HD-DEN-6372_HD Rinseback
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Fixed.

Need to fix doxygen style. @details Inputs: @details Outputs:

Need to fix doxygen style.
@details Inputs:
@details Outputs:

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.