common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Mar 2021
4:56 pm

Sean Nash

Did you add a call to this function in PriorityTask.c?

Did you add a call to this function in PriorityTask.c?

4:55 pm

Sean Nash

I don't think you need ModeTreatmentParams.h or OperationModes.h.

I don't think you need ModeTreatmentParams.h or OperationModes.h.

1:34 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:31 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:30 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:22 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:19 pm

Sean Nash

Also mention return value in @return of header.

Also mention return value in @return of header.

1:17 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:16 pm

Sean Nash

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

1:14 pm

Sean Nash

I expected to see a couple new cases here for handling override commands.

I expected to see a couple new cases here for handling override commands.

1:10 pm

Sean Nash

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

1:10 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:07 pm

Sean Nash

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

1:04 pm

Sean Nash

Consider merging these two declarations.

Consider merging these two declarations.

12:13 pm

pmontazemi  (deleted user)

HD-DEN-6890_Fluid Leak Detector Driver
HD-DEN-6890_Fluid Leak Detector Driver
Thursday 04 Mar 2021
10:47 am

Sean Nash

10:45 am

Dara Navaei , pmontazemi  (deleted user) and qnguyen  (deleted user)

9:34 am

Sean Nash

HD-DEN-6372_HD Rinseback
HD-DEN-6372_HD Rinseback
Wednesday 03 Mar 2021
10:58 am

Dara Navaei

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

Fixed.

Fixed.

10:27 am

qnguyen  (deleted user)

Need to fix doxygen style. @details Inputs: @details Outputs:

Need to fix doxygen style.
@details Inputs:
@details Outputs:

Monday 01 Mar 2021
10:39 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.