common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Replace 0x40 with constant and define it at beginning of *.c file.

Replace 0x40 with constant and define it at beginning of *.c file.

Replace 0x3F with constant and define it at beginning of *.c file.

Replace 0x3F with constant and define it at beginning of *.c file.

Replace 0x80 with constant and define it at beginning of *.c file.

Replace 0x80 with constant and define it at beginning of *.c file.

Use 10 instead of ten (easier to track and compare).

Use 10 instead of ten (easier to track and compare).

Use 5 instead of five (easier to track and compare).

Use 5 instead of five (easier to track and compare).

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold. This function makes sure all ...

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold.
This function makes sure all of them are below the threshold.

I think memset is in string.h. Should you add a #include <string.h> at top of module?

I think memset is in string.h. Should you add a #include <string.h> at top of module?

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?

Was this function temporary too?

Was this function temporary too?

I think this should be an and because of the "whichever is greater" part of the condition.

I think this should be an and because of the "whichever is greater" part of the condition.

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to...

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to alarm on a percentage basis. Likewise, if delta is > 0.1 mL but error is < 5%, no alarm.

Should this be an or?

Should this be an or?

Should this be an or?

Should this be an or?

The above line has been removed.

The above line has been removed.

Done.

Done.

This function has been removed.

This function has been removed.

This function has been removed.

This function has been removed.

This function has been removed.

This function has been removed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

It will be addressed in the future stories.

It will be addressed in the future stories.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

It will be addressed in the future stories.

It will be addressed in the future stories.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.