common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I am referring to the comment.

I am referring to the comment.

I am referring to the comment.

I am referring to the comment.

Yes. It should be removed or refactored once the actual blood leak self-test functionality is implemented.

Yes. It should be removed or refactored once the actual blood leak self-test functionality is implemented.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Replace 0x40 with constant and define it at beginning of *.c file.

Replace 0x40 with constant and define it at beginning of *.c file.

Replace 0x3F with constant and define it at beginning of *.c file.

Replace 0x3F with constant and define it at beginning of *.c file.

Replace 0x80 with constant and define it at beginning of *.c file.

Replace 0x80 with constant and define it at beginning of *.c file.

Use 10 instead of ten (easier to track and compare).

Use 10 instead of ten (easier to track and compare).

Use 5 instead of five (easier to track and compare).

Use 5 instead of five (easier to track and compare).

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold. This function makes sure all ...

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold.
This function makes sure all of them are below the threshold.

I think memset is in string.h. Should you add a #include <string.h> at top of module?

I think memset is in string.h. Should you add a #include <string.h> at top of module?

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?

Is this function necessary? Couldn't you just call the function above and look for FALSE return value?