common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 08 Apr 2021
12:18 pm

pmontazemi  (deleted user)

Comments shall start with capital letter.

Comments shall start with capital letter.

12:12 pm

pmontazemi  (deleted user)

Replace a with a more meaningful variable name.

Replace a with a more meaningful variable name.

12:06 pm

pmontazemi  (deleted user)

Align comment.

Align comment.

11:28 am

pmontazemi  (deleted user)

Align comment.

Align comment.

11:27 am

pmontazemi  (deleted user)

Add TODO or delete.

Add TODO or delete.

11:27 am

pmontazemi  (deleted user)

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

Replace logic with a temp parameter (call it whatever you like) and then use that parameter in the function call. This will make the code a lot more legible.

11:25 am

pmontazemi  (deleted user)

Why not using a union? Much more optimized for memory-limited devices.

Why not using a union? Much more optimized for memory-limited devices.

11:17 am

pmontazemi  (deleted user)

Where did these go?

Where did these go?

11:17 am

pmontazemi  (deleted user)

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

11:17 am

pmontazemi  (deleted user)

Remove "for" at end of @param sentence.

Remove "for" at end of @param sentence.

11:15 am

pmontazemi  (deleted user)

Why using structs instead of enums?

Why using structs instead of enums?

11:14 am

pmontazemi  (deleted user)

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

11:14 am

pmontazemi  (deleted user)

...operating temperatures between 5 degrees C and 95 degrees C.

...operating temperatures between 5 degrees C and 95 degrees C.

10:54 am

pmontazemi  (deleted user)

Why commented out?

Why commented out?

10:54 am

pmontazemi  (deleted user)

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

10:52 am

pmontazemi  (deleted user)

Why commented out?

Why commented out?

10:50 am

pmontazemi  (deleted user)

Spell out P in variable name (or use "Press" at least).

Spell out P in variable name (or use "Press" at least).

10:48 am

pmontazemi  (deleted user)

Did we want to mention "set" in the two variables' name?

Did we want to mention "set" in the two variables' name?

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

Need to add state machine in this function. Call state handler functions from a switch statement.

Need to add state machine in this function. Call state handler functions from a switch statement.

10:31 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

10:29 am

Sean Nash

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

10:28 am

qnguyen  (deleted user)

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.

10:25 am

pmontazemi  (deleted user)

One is for the Blood Leak Detector status (blood leaked or blood not leaked), and the other one is for the Blood Leak Detector state of its state machine. This is just in case we wanted to have ind...

One is for the Blood Leak Detector status (blood leaked or blood not leaked), and the other one is for the Blood Leak Detector state of its state machine. This is just in case we wanted to have independent control over these time constants.

10:23 am

Sean Nash

But they could be packaged together into once blood leak data broadcast message.

But they could be packaged together into once blood leak data broadcast message.

10:20 am

Sean Nash

This is more of a request to run a self test by a mode (probably pre-treatment mode), so I think boolean is appropriate to indicate request was accepted.

This is more of a request to run a self test by a mode (probably pre-treatment mode), so I think boolean is appropriate to indicate request was accepted.

10:18 am

qnguyen  (deleted user)

Temperature values have been extracted out from treatment parameters in HD-DEN-7091.

Temperature values have been extracted out from treatment parameters in HD-DEN-7091.

10:15 am

Sean Nash

What is the difference between this interval override and the one below? If monitor is broadcasting 2 different messages, why? Recommend combining published blood leak data into one message.

What is the difference between this interval override and the one below? If monitor is broadcasting 2 different messages, why? Recommend combining published blood leak data into one message.