common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I agree, but sometimes feel it helps readability.

I agree, but sometimes feel it helps readability.

Yes, you are right. I will use fwcommon code.

Yes, you are right. I will use fwcommon code.

Fixed.

Fixed.

What declaration?

What declaration?

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

Parentheses unnecessary.

Parentheses unnecessary.

== FALSE instead of != TRUE?

== FALSE instead of != TRUE?

No more self-test (and associated self-test state machine) for heparin pump?

No more self-test (and associated self-test state machine) for heparin pump?

Change comment from 11 ml to 13 ml if 13 ml is the current placeholder.

Change comment from 11 ml to 13 ml if 13 ml is the current placeholder.

Fix which test to get 1000 ms?

Fix which test to get 1000 ms?

Add blank line between declaration and code.

Add blank line between declaration and code.

Persistence spell error.

Persistence spell error.

Should all these alarms be using persistent alarm module from fwcommon? Using persistent alarm module will save some dev test time later on.

Should all these alarms be using persistent alarm module from fwcommon? Using persistent alarm module will save some dev test time later on.

HD-DEN-7605_HD DG Self Tests
HD-DEN-7605_HD DG Self Tests
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.