common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 27 Jul 2021
11:11 am

qnguyen  (deleted user)

Sent events only for changed settings.

Sent events only for changed settings.

11:04 am

qnguyen  (deleted user)

Set UF volume initially to 0 and removed this variable and related function.

Set UF volume initially to 0 and removed this variable and related function.

11:01 am

qnguyen  (deleted user)

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

10:54 am

qnguyen  (deleted user)

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

10:49 am

qnguyen  (deleted user)

Dara Navaei Please take a look.

Dara Navaei Please take a look.

10:49 am

qnguyen  (deleted user)

This message is requested by UI. UI wants to keep it consistent with other request message, in case there is reject reason in the future.

This message is requested by UI. UI wants to keep it consistent with other request message, in case there is reject reason in the future.

10:48 am

qnguyen  (deleted user)

Removed.

Removed.

10:38 am

qnguyen  (deleted user)

If fault mode calls the treatment log data collect function, the record can be zeroed also.

If fault mode calls the treatment log data collect function, the record can be zeroed also.

10:33 am

qnguyen  (deleted user)

The transition function will call this init function.

The transition function will call this init function.

10:27 am

qnguyen  (deleted user)

Done.

Done.

10:25 am

qnguyen  (deleted user)

Fixed.

Fixed.

10:24 am

qnguyen  (deleted user)

Fixed.

Fixed.

10:19 am

qnguyen  (deleted user)

Done.

Done.

10:18 am

qnguyen  (deleted user)

The else is when AC power detected. Added clear alarm condition.

The else is when AC power detected. Added clear alarm condition.

Monday 26 Jul 2021
10:31 am

Sean Nash

Should we close both drain valves VRd1 and VRd2 here?

Should we close both drain valves VRd1 and VRd2 here?

10:24 am

Sean Nash

I think other fill volumes would come from HD, so we can remove this TODO.

I think other fill volumes would come from HD, so we can remove this TODO.

10:21 am

Sean Nash

The GPIO register is shared (e.g. see fluid leak in above function). So I think we should have separate functions for each bit that we use in the GPIO register. Also - why does the function name ha...

The GPIO register is shared (e.g. see fluid leak in above function). So I think we should have separate functions for each bit that we use in the GPIO register.
Also - why does the function name have the word Count in it?

10:17 am

Sean Nash

Please restore the vector length test.

Please restore the vector length test.

10:12 am

Sean Nash

How is this used?

How is this used?

10:10 am

Sean Nash

I think these @param descriptions could fit in one line for a cleaner look.

I think these @param descriptions could fit in one line for a cleaner look.

10:07 am

Sean Nash

For consistency, can we put Dialin functions at end?

For consistency, can we put Dialin functions at end?

10:00 am

Sean Nash

Compatibility check should be before FPGA test at end where it was. We can't do it this early because UI may not have provided us with version/compatibility info yet.

Compatibility check should be before FPGA test at end where it was. We can't do it this early because UI may not have provided us with version/compatibility info yet.

9:53 am

Sean Nash

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

9:50 am

Sean Nash

Not sure this variable (and related get function) are needed.

Not sure this variable (and related get function) are needed.

9:49 am

Sean Nash

User may not have changed all 4 settings. Should we only send events for those that actually changed?

User may not have changed all 4 settings. Should we only send events for those that actually changed?

9:41 am

Sean Nash

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

9:39 am

Sean Nash

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

9:34 am

Sean Nash

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.

9:32 am

Sean Nash

Why not zero record here? I see it is zeroed just prior to creation at end of treatment, but that means this record may have prior treatment's data until current treatment is over.

Why not zero record here? I see it is zeroed just prior to creation at end of treatment, but that means this record may have prior treatment's data until current treatment is over.

9:18 am

Sean Nash

If typical h/w response is very quick (e.g. < 1ms) and worst case is still pretty quick (e.g. < 5ms), then I think this is ok with the t/o there to prevent getting stuck in loop forever. Also, batt...

If typical h/w response is very quick (e.g. < 1ms) and worst case is still pretty quick (e.g. < 5ms), then I think this is ok with the t/o there to prevent getting stuck in loop forever.
Also, battery monitor is called from background task so we can be a little more relaxed about this.