Activity common/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	18
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 03 Nov 2021

3:09 pm

Sean Nash

More
ce2b5be
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

- -3
- +3
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -1
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

3:09 pm

Sean Nash

More
b0bfee1
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more DG-UCOMMITS-38

DEN-9906: Updated syringe alarm properties. Removed obsoleted alarms and messages associated with removed components.

- -24
- +24
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -4
- +4
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:31 pm

Dara Navaei

More
8007072
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1 UI-UCOMMITS-26

DEN-9480 added the dialysate drain timeout alarm

- -3
- +3
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

2:17 pm

Dara Navaei

More
c12022d
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

DEN-9480 added a drain pump RPM override command

- -1
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

Monday 01 Nov 2021

10:19 am

Sean Nash

More
Re: HD-DEN-9906-1
replied to hnguyen (deleted user)

Added file header.

Added file header.

9:31 am

Sean Nash

More
e5e26d3
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 197 more

Merge branch 'staging' into develop

9:28 am

Sean Nash

More
602bee3
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

DEN-9906: removed obsolete comments.

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h

9:25 am

Dara Navaei

More
d2eec46
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 197 more

Merge branch 'staging' into develop

Friday 29 Oct 2021

3:30 pm

Dara Navaei

More
0efc49e
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

DEN-9480 renamed the RTC stop command message IDs.

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

1:37 pm

Hung Nguyen <hnguyen@diality.com>

More
e212e13
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 197 more

Merge branch 'staging' into develop

Thursday 28 Oct 2021

10:59 pm

Dara Navaei

More
860d06e
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

DEN-9480 added command message to start and stop the HD and DG RTC clock

- -0
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

10:27 am

Dara Navaei

More
d6d2aa0
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

DEN-9480 renamed the drain pump outlet pressure sensor

- -1
- +1
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

Wednesday 27 Oct 2021

4:12 pm

Sean Nash

More
3aff2b2
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-10602_UI_DEV_Add_PatientID_PreTreatment and 203 more HD-DEN-9906-1

DEN-9906: Added message IDs for override of arterial pressure offset and blood pump rotor count.

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

10:48 am

hnguyen (deleted user)

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:48 am

hnguyen (deleted user)

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:48 am

hnguyen (deleted user)

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:47 am

hnguyen (deleted user)

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:45 am

hnguyen (deleted user)

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:40 am

Behrouz NematiPour

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

10:39 am

Behrouz NematiPour

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

10:37 am

Behrouz NematiPour

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

10:36 am

Behrouz NematiPour

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

8:49 am

Sean Nash

More
Re: HD-DEN-9906-1
replied to hnguyen (deleted user)

Fixed.

Fixed.

8:43 am

Sean Nash

More
Re: HD-DEN-9906-1
replied to hnguyen (deleted user)

Fixed.

Fixed.

8:41 am

Sean Nash

More
Re: HD-DEN-9906-1
replied to hnguyen (deleted user)

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead. Otherwise, I like to put the literal last because it reads be...

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead.
Otherwise, I like to put the literal last because it reads better.

8:38 am

Sean Nash

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

8:36 am

Sean Nash

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the ...

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the two values that you are toggling between.

8:34 am

Sean Nash

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety. So the way I have it now, if isBloodPumpRunning() g...

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety.
So the way I have it now, if isBloodPumpRunning() gets corrupted to > 1, it will consider that the pump is not running which is the safer thing to do.

8:30 am

Sean Nash

currentSubMode is already a U32 - no cast needed.

currentSubMode is already a U32 - no cast needed.

Tuesday 26 Oct 2021

10:24 pm

Behrouz NematiPour

More
Re: HD-DEN-9906-1
commented on review

Shouldn't be? ( FALSE == isBloodPumpRunning() )

Shouldn't be?

( FALSE == isBloodPumpRunning() )

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-24 15:12 -0800