common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here.

This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here.

Why reset start time here?

Why reset start time here?

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

Make it clearer that this is for prime dialyzer state.

Make it clearer that this is for prime dialyzer state.

Dialyzer is spelled with a "z" not "s".

Dialyzer is spelled with a "z" not "s".

I would rename to something like prime dialyzer stop weight.

I would rename to something like prime dialyzer stop weight.

HD-DEN-11098_Implement HD Pre Treatment Mode Update
HD-DEN-11098_Implement HD Pre Treatment Mode Update
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

RESOLVED in CODE WALKTHROUGH. (On behalf of Behrouz NematiPour who is on vacation)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Removed.

Removed.

Adjust the space before the equal signs.

Adjust the space before the equal signs.

I adjusted spaces "before" the equal sign.

I adjusted spaces "before" the equal sign.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule. If you think it should be added to our standard, let's discuss.

Our coding standard does not require MISRA compliance and I don't think our coding standard includes this if else rule.
If you think it should be added to our standard, let's discuss.

Added comment.

Added comment.

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone. Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

I wasn't sure what flow sensor "response" registers were - moot now that sensors are gone.
Still unsure what to do with processor/pc error counts - will resolve this in a future branch.

Why there are TBDs in the comments?

Why there are TBDs in the comments?