common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Mar 2022
11:49 am

Michael Garthwaite

DEN-12121: Updated HD communication status override to use message id 0xA008 per peer review

Options
    • -1
    • +1
    /MsgDefs.h
11:42 am

Dara Navaei

Merged DEN-12224

Options
    • -0
    • +21
    /HDDefs.h
    • -1
    • +0
    /MsgDefs.h
11:41 am

Dara Navaei

DEN-12224 moved the wet self tests to HDDefs.h

Options
    • -0
    • +21
    /HDDefs.h
11:27 am

dcox  (deleted user)

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Tuesday 08 Mar 2022
9:27 pm

Dara Navaei

DEN-12224 updated the DG fans RPM alarm start time offset message ID.

Options
    • -1
    • +1
    /MsgDefs.h
4:57 pm

Dara Navaei

Merged DEN-12224 and resolved the merge conflicts

Options
    • -8
    • +14
    /MsgDefs.h
4:34 pm

Michael Garthwaite

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

4:33 pm

Michael Garthwaite

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

4:28 pm

Sean Nash

Should we check pump track switch too?

Should we check pump track switch too?

4:28 pm

Sean Nash

Should we check pump track switch too?

Should we check pump track switch too?

4:26 pm

Sean Nash

Why does door need to be closed for this state?

Why does door need to be closed for this state?

4:24 pm

Sean Nash

Do we want to check pump track switch too?

Do we want to check pump track switch too?

4:23 pm

Sean Nash

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs a...

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs and in that state the user should be allowed to open the door to possibly address the issue.
So I think we need to figure out how to exempt those alarm states.

4:07 pm

Sean Nash

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly afte...

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly after HALCoGen updates this file.

3:59 pm

Sean Nash

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrid...

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrides when clearing alarm conditions.

3:45 pm

Dara Navaei

DEN-12224, DEN-12232 added a message ID to set the fans RPM alarm start time offset

Options
    • -2
    • +4
    /MsgDefs.h
Monday 07 Mar 2022
8:19 pm

Dara Navaei

DEN-12224 removed the heaters' internal temperatuer alarms

Options
    • -12
    • +12
    /AlarmDefs.h
4:57 pm

Hung Nguyen <hnguyen@diality.com>

Merge branch 'DEN-11928-dg-conductivity-update' of ssh://dvm-linux02:7999/comm/common into DEN-11928-dg-conductivity-update

Options
    • -1
    • +1
    /AlarmDefs.h
4:56 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Added alarm

Options
    • -3
    • +3
    /AlarmDefs.h
2:33 pm

Sean Nash

DEN-12224: Removed No New Treatment alarm property and cleaned up alarm table.

Options
    • -310
    • +309
    /AlarmDefs.h
    • -1
    • +1
    /MsgDefs.h
11:23 am

hnguyen  (deleted user)

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

11:19 am

hnguyen  (deleted user)

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

11:19 am

hnguyen  (deleted user)

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

10:34 am

hnguyen  (deleted user)

Uncommented and recompiled without errors

Uncommented and recompiled without errors

Sunday 06 Mar 2022
8:57 pm

Dara Navaei

Align the comment.

Align the comment.

8:43 pm

Dara Navaei

Why was this include removed? Do you not need it for the treatment parameters commands?

Why was this include removed? Do you not need it for the treatment parameters commands?

8:38 pm

Dara Navaei

This should be a BOOL since you are suing this as a boolean.

This should be a BOOL since you are suing this as a boolean.

Friday 04 Mar 2022
9:37 pm

Dara Navaei

HD-DEN-12215_SW Dev Sprint 65 Darren
HD-DEN-12215_SW Dev Sprint 65 Darren
2:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:36 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.