common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12121: Updated HD communication status override to use message id 0xA008 per peer review

Merged DEN-12224

DEN-12224 moved the wet self tests to HDDefs.h

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

DEN-12224 updated the DG fans RPM alarm start time offset message ID.

Merged DEN-12224 and resolved the merge conflicts

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

Should we check pump track switch too?

Should we check pump track switch too?

Should we check pump track switch too?

Should we check pump track switch too?

Why does door need to be closed for this state?

Why does door need to be closed for this state?

Do we want to check pump track switch too?

Do we want to check pump track switch too?

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs a...

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs and in that state the user should be allowed to open the door to possibly address the issue.
So I think we need to figure out how to exempt those alarm states.

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly afte...

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly after HALCoGen updates this file.

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrid...

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrides when clearing alarm conditions.

DEN-12224, DEN-12232 added a message ID to set the fans RPM alarm start time offset

DEN-12224 removed the heaters' internal temperatuer alarms

Merge branch 'DEN-11928-dg-conductivity-update' of ssh://dvm-linux02:7999/comm/common into DEN-11928-dg-conductivity-update

DEN-11928 Added alarm

DEN-12224: Removed No New Treatment alarm property and cleaned up alarm table.

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Uncommented and recompiled without errors

Uncommented and recompiled without errors

Align the comment.

Align the comment.

Why was this include removed? Do you not need it for the treatment parameters commands?

Why was this include removed? Do you not need it for the treatment parameters commands?

This should be a BOOL since you are suing this as a boolean.

This should be a BOOL since you are suing this as a boolean.

HD-DEN-12215_SW Dev Sprint 65 Darren
HD-DEN-12215_SW Dev Sprint 65 Darren
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.