common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

RESOLVED in WALKTHROUGH.

It is zeroed in transition function and it is not used until the acid state.

It is zeroed in transition function and it is not used until the acid state.

Done.

Done.

It is initialized in the init function and it is staggered.

It is initialized in the init function and it is staggered.

Initialized hdLostCommStartTime_ms in void initGenIdleMode( void )

Initialized hdLostCommStartTime_ms
in void initGenIdleMode( void )

did we want to keep these loose tolerances from the demo?

did we want to keep these loose tolerances from the demo?

We typically put #define like this in the source file. Is there a reason why this one is in the header file specifically?

We typically put #define like this in the source file. Is there a reason why this one is in the header file specifically?

This variable is defined but not used.

This variable is defined but not used.

Changed TxLog field from TRUE to FALSE

Changed TxLog field from TRUE to FALSE

Moved publishBadFillSubstates(); to the end of execGenIdle function

Moved publishBadFillSubstates(); to the end of execGenIdle function

Added test separator below /************************************************************************* *TEST SUPPORT FUNCTIONS *********************************************************************...

Added test separator below
/*************************************************************************

  • TEST SUPPORT FUNCTIONS
    *************************************************************************/
deleted blank line

deleted blank line

Aligned this comment with other comments ///< Used to schedule dialysate fill data publication to CAN bus.

Aligned this comment with other comments
///< Used to schedule dialysate fill data publication to CAN bus.

I wanted to see how new #define worked. I think it's better, so we can remove this now.

I wanted to see how new #define worked. I think it's better, so we can remove this now.

Doesn't next state need acid zeroed here?

Doesn't next state need acid zeroed here?

Stagger?

Stagger?

delete one of these blank lines.

delete one of these blank lines.

Indent comment properly.

Indent comment properly.

Add test functions banner separator here.

Add test functions banner separator here.

I would move this to end of function in case state machine changes the state.

I would move this to end of function in case state machine changes the state.