common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14197: DIAL-200: DIAL-212: Changed msg id values for ro feedback and dialysate fill total volume to prevent merge conflicts

DEN-14197: DIAL-200: DIAL-212: Changed msg id values for ro feedback and dialysate fill total volume to prevent merge conflicts

DEN-14197: DIAL-200: DIAL-212: MSG ID's for ro feedback voltage and dialysate fill total volume overrides

This is here so both stacks can use it.

This is here so both stacks can use it.

Done.

Done.

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove blank line.

Remove blank line.

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Merge branch 'staging' into DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Looks like blank line is still there.

Looks like blank line is still there.

Done.

Done.

Done.

Done.

Merge branch 'DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5' into develop

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Update function header.

Update function header.

Remove blank line

Remove blank line

DEN-14175 addressed a code reivew comment

Done.

Done.

This function should stay commented. I have a TODO task for this.

This function should stay commented. I have a TODO task for this.

Done.

Done.

No these should be TRUE.

No these should be TRUE.

Merged DEN-14175

DEN-14175 updated the DG logging messages