Activity common/

9:50 am

Michael Garthwaite

More
7809b6e
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 167 more HD-DEN-14344-3

DEN-14344: fixes

- -4
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

9:48 am

Michael Garthwaite

More
9c0224a
changed 1 file
develop

Merge branch 'DEN-14344-sw-s85-mg-air-pump' into develop

- -3
- +6
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

9:37 am

jtaylor (deleted user)

More
Re: HD-DEN-14252-1
commented on review

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

9:25 am

Michael Garthwaite

More
6a5a5a8
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 167 more HD-DEN-14344-3

DEN-14344: Message id updates to air pump.

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:35 pm

Dara Navaei

More
3f2a323
changed 3 files
develop

Merged DEN-14252

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -0
- +4
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h
- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:31 pm

Dara Navaei

More
c3f98e7
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 171 more HD-DEN-14252-1

DEN-14252 added new load cells HD events list

- -0
- +4
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

3:18 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

3:13 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove

3:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove.

3:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Think the deleted def is correct.

3:09 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

3:08 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove.

3:08 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

2:55 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Alignment

2:53 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove.

2:50 pm

wbracken (deleted user)

More
Re: DG-DEN-14316-1
commented on review

Remove blank lines and commented out ode.

6:56 pm

Steve Jarpe <sjarpe@diality.com>

More
fa5c4d6
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 170 more DG-DEN-14316-1

DEN-14316-chemical-disinfect. Defs for ModeChemicalDisinfectFlush

- -7
- +9
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h
- -17
- +21
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h
- -0
- +5
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

10:31 am

jtaylor (deleted user)

More
HD-DEN-14307-1
resumed reviewing

4:17 pm

wbracken (deleted user)

More
Re: HD-DEN-14344-3
commented on review

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

4:05 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

2:02 pm

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to wbracken (deleted user)

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

1:53 pm