common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Dec 2022
4:38 pm

Sean Nash

Keep blank line before return statement.

Keep blank line before return statement.

4:36 pm

Sean Nash

Check indent.

Check indent.

4:35 pm

Sean Nash

Body start bracket indented too far.

Body start bracket indented too far.

4:34 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

4:32 pm

Sean Nash

Can these 2 declarations be moved up with the others (above "ifndef_RELEASE_")?

Can these 2 declarations be moved up with the others (above "ifndef_RELEASE_")?

4:26 pm

Sean Nash

Prefer to have declarations of local variables at top of scope where they are used.

Prefer to have declarations of local variables at top of scope where they are used.

4:24 pm

Sean Nash

Align.

Align.

4:24 pm

Sean Nash

Should have a default case with s/w fault or something.

Should have a default case with s/w fault or something.

4:24 pm

Sean Nash

Ok to not do anything for these cases, but put a comment in here so we know this is intentional.

Ok to not do anything for these cases, but put a comment in here so we know this is intentional.

4:23 pm

Sean Nash

Alignment.

Alignment.

4:22 pm

Sean Nash

Remove blank line.

Remove blank line.

4:22 pm

Sean Nash

Has this been decided yet?

Has this been decided yet?

4:21 pm

Sean Nash

Remove blank line.

Remove blank line.

4:21 pm

Sean Nash

Align = or bring back to state.

Align = or bring back to state.

4:19 pm

Sean Nash

Align.

Align.

4:19 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

4:18 pm

Sean Nash

Align.

Align.

4:18 pm

Sean Nash

Align.

Align.

4:18 pm

Sean Nash

Align else body brackets.

Align else body brackets.

4:17 pm

Sean Nash

Align.

Align.

4:17 pm

Sean Nash

Align comment.

Align comment.

4:17 pm

Sean Nash

Align = or bring next to state.

Align = or bring next to state.

4:16 pm

Sean Nash

This already called in transition into this mode.

This already called in transition into this mode.

4:13 pm

Sean Nash

..CHEM_DISINFECT_FLUSH_INVALID_EXEC_STATE

..CHEM_DISINFECT_FLUSH_INVALID_EXEC_STATE

4:09 pm

Sean Nash

"Flusht" - remove t at end of Flush.

"Flusht" - remove t at end of Flush.

4:09 pm

Sean Nash

DGChemicalDisinfectFlushMode

DGChemicalDisinfectFlushMode

4:01 pm

Sean Nash

File header?

File header?

4:00 pm

Sean Nash

Disagree. This is ModeFlush.c. Looks correct in last commit.

Disagree. This is ModeFlush.c. Looks correct in last commit.

3:54 pm

Sean Nash

Should not allow transition from fault mode to chem flush mode.

Should not allow transition from fault mode to chem flush mode.

3:52 pm

Sean Nash

Change both sizeof() calls to BOOL to match type of local var destination of your memcpy(). All are 4 bytes - just for consistency and in case BOOL gets changed.

Change both sizeof() calls to BOOL to match type of local var destination of your memcpy(). All are 4 bytes - just for consistency and in case BOOL gets changed.