common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Dec 2022
10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of co...

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of code unless there is a good reason (e.g. a dependency in assignment on code above).

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

Align "="s.

Align "="s.

9:51 am

Sean Nash

Alignment - why is "=" pushed out so far?

Alignment - why is "=" pushed out so far?

9:46 am

Sean Nash

Align "="s.

Align "="s.

9:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:43 am

Sean Nash

I searched this file for tabs and replaced them with 4 spaces. Please check your editor tab settings. RESOLVED in CODE WALKTHROUGH.

I searched this file for tabs and replaced them with 4 spaces. Please check your editor tab settings.
RESOLVED in CODE WALKTHROUGH.

9:42 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:14 am

Steve Jarpe

To be clear, does this mean all of the local declarations should be at the beginning of the function?

To be clear, does this mean all of the local declarations should be at the beginning of the function?

6:27 am

Steve Jarpe

I can't see this in Code Composer Studio.

I can't see this in Code Composer Studio.

6:26 am

Steve Jarpe

I can't see this in Code Composer Studio.

I can't see this in Code Composer Studio.

Monday 19 Dec 2022
6:08 pm

Sean Nash

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

6:01 pm

Sean Nash

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

6:00 pm

Sean Nash

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

5:58 pm

Sean Nash

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

5:57 pm

Sean Nash

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while...

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while VBT is open.

5:43 pm

Sean Nash

Indent 2nd and 3rd line of if by 2 more spaces.

Indent 2nd and 3rd line of if by 2 more spaces.

5:43 pm

Sean Nash

Capitalize Level and Ctr. Add doxygen comment.

Capitalize Level and Ctr. Add doxygen comment.

5:42 pm

Sean Nash

Should be a group ending /*@}/ at bottom here.

Should be a group ending /*@}/ at bottom here.

5:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.