common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Dec 2022
4:19 pm

Steve Jarpe <sjarpe@diality.com>

/DEN-14316-chemical-disinfect. Code review changes

Options
    • -5
    • +0
    /DGDefs.h
4:17 pm

Michael Garthwaite

Merge branch 'DEN-14344-sw-s85-mg-air-pump' into develop

Options
    • -0
    • +4
    /AlarmDefs.h
    • -2
    • +2
    /HDDefs.h
4:17 pm

Steve Jarpe

Actually the only other place I could put them is at the top of the function.

Actually the only other place I could put them is at the top of the function.

4:16 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:16 pm

Michael Garthwaite

DEN-14344: fixed alarm id table

Options
    • -1
    • +1
    /AlarmDefs.h
4:14 pm

Steve Jarpe

removed

removed

4:13 pm

Steve Jarpe

Not sure.

Not sure.

4:13 pm

Steve Jarpe

I am not sure what should be done.

I am not sure what should be done.

4:12 pm

Steve Jarpe

I would need some help with this.

I would need some help with this.

4:11 pm

Steve Jarpe

Removed it this time.

Removed it this time.

4:11 pm

Steve Jarpe

OK, now I see. I removed this one. There are others, should I remove them also?

OK, now I see. I removed this one. There are others, should I remove them also?

3:59 pm

Steve Jarpe

Done

Done

3:42 pm

Steve Jarpe

The declarations have been moved higher, as in ModeChemicalDisinfectFlush

The declarations have been moved higher, as in ModeChemicalDisinfectFlush

3:41 pm

Steve Jarpe

The lines have been moved.

The lines have been moved.

3:40 pm

Steve Jarpe

removed

removed

3:34 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:30 pm

Steve Jarpe

Fixed

Fixed

3:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

3:22 pm

Sean Nash

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

3:15 pm

Sean Nash

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

2:29 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:18 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:17 pm

wbracken  (deleted user)

Remove blank line.

Remove blank line.

2:14 pm

wbracken  (deleted user)

Should these two lines be deleted?

Should these two lines be deleted?

2:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:09 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:06 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.