common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

Done.

Done.

Done.

Done.

Done.

Done.

Should be removed?

Should be removed?

The description seems to be missing a few words.

The description seems to be missing a few words.

Add heaterStatus to header.

Add heaterStatus to header.

Header needs to be updated.

Header needs to be updated.

Alignment.

Alignment.

Add dataPublishCounter, genIdleDataPublicationInterval, handleBadFillFlag, badFillState, targetFillVolumeML.

Add dataPublishCounter, genIdleDataPublicationInterval, handleBadFillFlag, badFillState, targetFillVolumeML.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Remove extra blank line.

Remove extra blank line.

Fix indents. Consider using /// comment above this declaration instead of inline ///< comment at end.

Fix indents. Consider using /// comment above this declaration instead of inline ///< comment at end.

Remove extra blank line.

Remove extra blank line.

For a release build, looks like we would do nothing and get stuck in this state.

For a release build, looks like we would do nothing and get stuck in this state.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

DG-DEN-14101_SW S82 MG Dial 179 Dial 18
DG-DEN-14101_SW S82 MG Dial 179 Dial 18
DG-DEN-14497_DG HD Dev HD DG Dvt Update Part 7
DG-DEN-14497_DG HD Dev HD DG Dvt Update Part 7
Fixed. Thanks!

Fixed. Thanks!

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.