common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14549: Changed user stop alarm from low to medium priority per PRS.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Seems like there are several variables missing.

Seems like there are several variables missing.

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Updated comment

Updated comment

DEN-14549: Changed empty syringe alarm to low priority and Ok button only.

DEN-13946 Update per code review

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Need to be careful with these. These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override v...

Need to be careful with these.
These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override variables though).
Also, since we are not re-initializing everything like a true reset does, we need to make sure that these modules are setup to restart or resume (whichever is more appropriate for the module) after POST completes if the module is in any way interrupted/deferred by POST or competing with POST for a resource/driver (e.g. RTC or NV-Data).

Variable should already be a BOOL.

Variable should already be a BOOL.

Set to TRUE here.

Set to TRUE here.

Initialize to FALSE.

Initialize to FALSE.

Rename to isDGFaultActive.

Rename to isDGFaultActive.

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

This alarm does not appear to be available. Correct description in last column (trigger condition).

This alarm does not appear to be available. Correct description in last column (trigger condition).

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done.

Done.

Done.

Done.

Done.

Done.

HD-DEN-14328_HD Event Issues
HD-DEN-14328_HD Event Issues
DEN-14549: Changed empty syringe pump alarm to not stop treatment - just need to acknowledge it.