common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Mar 2023
9:33 am

Sean Nash

Fixed.

Fixed.

9:32 am

Sean Nash

Fixed.

Fixed.

9:30 am

Sean Nash

Fixed.

Fixed.

Tuesday 07 Mar 2023
4:55 pm

Michael Garthwaite

Fixed?

Fixed?

4:53 pm

Michael Garthwaite

To answer this and comment below: above_high_safety_range = temp > 46 above_low_safety_range = temp > 42 above_target_temp = target + 4 below_target_temp = target - 4 below_low_safety_range = temp...

To answer this and comment below:

above_high_safety_range = temp > 46
above_low_safety_range = temp > 42
above_target_temp = target + 4
below_target_temp = target - 4
below_low_safety_range = temp < 33

I did not see any specification regarding to separate or not to separate. Original functionality had separate triggers. Respective PRS's state OR between the two triggers.
I think it would be clear to for us in terms of debugging to see which alarm is triggered since on the low side, temp - 4 would be lower than 33, (31).

Wording may be unclear. Im up for suggestions to help clarify the alarm differences.

4:42 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:35 pm

Michael Garthwaite

Shouldnt this be set to 0U instead of 0.0F?

Shouldnt this be set to 0U instead of 0.0F?

4:35 pm

Michael Garthwaite

This should be U32.

This should be U32.

4:35 pm

Michael Garthwaite

This should be U32.

This should be U32.

4:34 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:33 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:32 pm

Michael Garthwaite

Should we check for stall in bolus & continuous states?

Should we check for stall in bolus & continuous states?

4:27 pm

Michael Garthwaite

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

4:25 pm

Michael Garthwaite

Shouldnt this be set to 0U instead of 0.0F?

Shouldnt this be set to 0U instead of 0.0F?

4:01 pm

Dara Navaei

HD-DEN-14906_Dialyzer DE Prime
HD-DEN-14906_Dialyzer DE Prime
Monday 06 Mar 2023
11:37 am

Sean Nash

Fixed.

Fixed.

11:36 am

Sean Nash

Fixed.

Fixed.

10:03 am

Sean Nash

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm. And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm. D...

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm.
And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm.
Did Systems want to separate these? My understanding was not to separate.

Friday 03 Mar 2023
2:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 02 Mar 2023
10:29 am

Michael Garthwaite

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

10:28 am

Michael Garthwaite

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

10:21 am

Sean Nash

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

10:19 am

Sean Nash

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

10:18 am

Sean Nash

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

8:23 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Wednesday 01 Mar 2023
4:04 pm

Michael Garthwaite

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

4:04 pm

Michael Garthwaite

This will hard fault the HD. Please change to getTreatmentParameterU32()

This will hard fault the HD. Please change to getTreatmentParameterU32()

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH