common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14763 addressed the code review comments

Done. Thanks for catching it.

Done. Thanks for catching it.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Done

Done

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Missing comment?

Missing comment?

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Why lower case when others are uppercase?

Why lower case when others are uppercase?

Merge branch 'DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10' of ssh://devapps.diality.us:7999/comm/common into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

DEN-14763, DEN-14960 added an event to report the reservoir base weight and filled volume at the end of the fill

DEN-14763 merged staging

DEN-14763 updated the message name

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this ch...

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

Done

Done

Merge branch 'DEN-14689-messaging-bugs' into staging

Merge branch 'staging' into DEN-14689-messaging-bugs

DEN-14763 updated the messages list

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces