Activity common/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	18
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 20 Mar 2023

9:46 am

Dara Navaei

More
02e2e94
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more DG-DEN-14763-1

DEN-14763 addressed the code review comments

- -1
- +1
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

9:34 am

Dara Navaei

More
Re: DG-DEN-14763-1
replied to Sean Nash

Done. Thanks for catching it.

Done. Thanks for catching it.

9:33 am

Dara Navaei

More
77ddb0b
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more DG-DEN-14763-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

9:30 am

Michael Garthwaite

More
DG-DEN-14689-1
Closed

9:28 am

Dara Navaei

More
Re: DG-DEN-14763-1
replied to Sean Nash

Done

Done

9:28 am

Dara Navaei

More
Re: DG-DEN-14763-1
replied to Sean Nash

Done

Done

9:18 am

Sean Nash

More
DG-DEN-14689-1
finished reviewing

9:15 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:14 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

More
Re: DG-DEN-14646-1
commented on review

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

9:12 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:09 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:09 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:57 am

Sean Nash

More
Re: DG-DEN-14763-1
replied to jtaylor (deleted user)

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:43 am

Sean Nash

More
Re: DG-DEN-14763-1
commented on review

Missing comment?

Missing comment?

8:42 am

Sean Nash

More
Re: DG-DEN-14763-1
commented on review

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

8:36 am

Sean Nash

More
Re: DG-DEN-14763-1
commented on review

Why lower case when others are uppercase?

Why lower case when others are uppercase?

Sunday 19 Mar 2023

2:46 pm

Dara Navaei

More
ed3da53
changed 0 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more

Merge branch 'DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10' of ssh://devapps.diality.us:7999/comm/common into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

2:46 pm

Dara Navaei

More
8abf8d3
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more DG-DEN-14763-1

DEN-14763, DEN-14960 added an event to report the reservoir base weight and filled volume at the end of the fill

- -0
- +1
/DGDefs.h
- History
- Source
- Diff
/DGDefs.h

Saturday 18 Mar 2023

3:05 pm

Dara Navaei

More
e87512a
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more DG-DEN-14763-1

DEN-14763 merged staging

- -4
- +4
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -2
- +5
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

3:03 pm

Dara Navaei

More
f6f9859
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more DG-DEN-14763-1

DEN-14763 updated the message name

- -1
- +1
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:41 pm

Dara Navaei

More
Re: DG-DEN-14763-1
replied to Sean Nash

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this ch...

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

Friday 17 Mar 2023

2:42 pm

Dara Navaei

More
Re: DG-DEN-14763-1
replied to wbracken (deleted user)

Done

Done

1:56 pm

Michael Garthwaite

More
4463161
changed 0 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more

Merge branch 'DEN-14689-messaging-bugs' into staging

1:46 pm

Michael Garthwaite

More
7c1a444
changed 0 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 148 more

Merge branch 'staging' into DEN-14689-messaging-bugs

10:48 am

Dara Navaei

More
4148c89
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 147 more DG-DEN-14763-1

DEN-14763 updated the messages list

- -5
- +5
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

9:51 am

Sean Nash

More
HD-DEN-14888-1
Closed

9:34 am

Dara Navaei

More
defd596
changed 2 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 148 more DG-DEN-14763-1 HD-DEN-14830-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -2
- +2
/HDDefs.h
- History
- Source
- Diff
/HDDefs.h

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-13 03:24 -0800