common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Can we rename variable to reflect it is a timer counter at least?

Can we rename variable to reflect it is a timer counter at least?

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Fixed.

Fixed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes, and #define has "COUNT" in its name which was my point.

Yes, and #define has "COUNT" in its name which was my point.

Should venPres < venLowLimit be done outside if statement?

Should venPres < venLowLimit be done outside if statement?

DG-DEN-15014_DG HD Dev HD DG Dvt Update Part 11
DG-DEN-15014_DG HD Dev HD DG Dvt Update Part 11
Corrected

Corrected

Alarm is based on a counter. The #define corresponds to a 100ms time.

Alarm is based on a counter. The #define corresponds to a 100ms time.

Corrected

Corrected

Added DEBUG WARNING

Added DEBUG WARNING

DG-DEN-14999_Alarm Table Updates
DG-DEN-14999_Alarm Table Updates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

This seems wrong.

This seems wrong.

This seems wrong.

This seems wrong.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.