common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15199 updated the alarms properties table

Done.

Done.

Done.

Done.

Done

Done

Correct. This common code in between the two stacks. I can separate them using #ifndef.

Correct. This common code in between the two stacks. I can separate them using #ifndef.

Done

Done

Done

Done

I removed the memset macro.

I removed the memset macro.

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

Done

Done

Done

Done

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' into DEN-15183-in-treatment-rinseback-workflow-changes

Note in brief that function will return FALSE if Dialin not logged in.

Note in brief that function will return FALSE if Dialin not logged in.

testConfig is an input, not an output.

testConfig is an input, not an output.

Change "release" to "test".

Change "release" to "test".

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Add check for Dialin logged in.

Add check for Dialin logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Also, Dialin must be logged in to accept a test config command.

Also, Dialin must be logged in to accept a test config command.

memset wants a byte. Just say 0 instead of using KEY #define. Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

memset wants a byte. Just say 0 instead of using KEY #define.
Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

Add blank line between banner and #define.

Add blank line between banner and #define.

Add blank line between banner and #define.

Add blank line between banner and #define.

Are DG and HD sharing this enum?

Are DG and HD sharing this enum?

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ). Make this change everywhere getTestConfigStatus function is used.

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ).
Make this change everywhere getTestConfigStatus function is used.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH