common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Sep 2022
3:28 pm

wbracken  (deleted user)

Update header.

Update header.

3:28 pm

wbracken  (deleted user)

Update header?

Update header?

3:27 pm

Darren Cox

Should this be #elseif? Can DG AND HD both be defined or neither?

Should this be #elseif? Can DG AND HD both be defined or neither?

3:25 pm

wbracken  (deleted user)

Should 365 be #define? Why changed from #define to static const U32?

Should 365 be #define? Why changed from #define to static const U32?

3:23 pm

wbracken  (deleted user)

Should 250 be #define?

Should 250 be #define?

3:20 pm

wbracken  (deleted user)

Should struct members be aligned?

Should struct members be aligned?

10:13 am

wbracken  (deleted user)

Is this indentation correct?

Is this indentation correct?

10:07 am

wbracken  (deleted user)

How is the event calibration update record being used?

How is the event calibration update record being used?

9:56 am

Dara Navaei

HD-DEN-13903_Sprint 80 MG Air Trap Optimization
HD-DEN-13903_Sprint 80 MG Air Trap Optimization
9:41 am

Dara Navaei

HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
Friday 26 Aug 2022
3:02 pm

Michael Garthwaite

2:59 pm

Dara Navaei and Sean Nash

2:14 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:19 am

Michael Garthwaite

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

10:14 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

Thursday 25 Aug 2022
4:40 pm

Sean Nash

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

4:37 pm

Sean Nash

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

4:35 pm

Sean Nash

Remove all of these new blank lines.

Remove all of these new blank lines.

Wednesday 24 Aug 2022
4:52 pm

Dara Navaei

4:47 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!