common

MsgDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Feb 2021
10:56 pm

Dara Navaei

DEN-5980 added more message IDs and alarms for NV operations

Options
    • -1
    • +1
    /MsgDefs.h
  2. … 1 more file in changeset.
1:20 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:58 am

Sean Nash

Is that a rule in our coding standard?

Is that a rule in our coding standard?

11:22 am

Sean Nash

Fixed.

Fixed.

11:21 am

Sean Nash

Fixed.

Fixed.

11:17 am

Sean Nash

Done.

Done.

11:13 am

qnguyen  (deleted user)

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

11:04 am

qnguyen  (deleted user)

Right after the if statement ends.

Right after the if statement ends.

10:59 am

qnguyen  (deleted user)

Mismatch function name.

Mismatch function name.

10:52 am

Sean Nash

Divide by 2 is averaging start and end rates of the ramp so that I can determine estimate of time needed to complete the ramp.

Divide by 2 is averaging start and end rates of the ramp so that I can determine estimate of time needed to complete the ramp.

10:49 am

Sean Nash

Where?

Where?

10:48 am

qnguyen  (deleted user)

Need to review doxygen style in this file.

Need to review doxygen style in this file.

10:48 am

Sean Nash

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

10:47 am

qnguyen  (deleted user)

Remove doxygen comment.

Remove doxygen comment.

10:45 am

Sean Nash

Done.

Done.

10:44 am

Sean Nash

Fixed.

Fixed.

10:36 am

qnguyen  (deleted user)

Mismatch function name.

Mismatch function name.

10:35 am

qnguyen  (deleted user)

Consider changing 60 to SEC_PER_MIN.

Consider changing 60 to SEC_PER_MIN.

10:00 am

qnguyen  (deleted user)

We are taking both actions on the same reservoir. Sean Nash can provide more details.

We are taking both actions on the same reservoir. Sean Nash can provide more details.

Monday 15 Feb 2021
2:15 pm

Dara Navaei

DEN-5980 added more message IDs. Removed the older message IDs that were used for calibation

Options
    • -7
    • +7
    /MsgDefs.h
1:27 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:27 pm

pmontazemi  (deleted user)

Should not there be two IDs we are passing in? i.e., are we taking both actions on the same reservoir?

Should not there be two IDs we are passing in? i.e., are we taking both actions on the same reservoir?

1:25 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Sunday 14 Feb 2021
2:06 pm

Dara Navaei

HD-DEN-5980_Non Volatile Data Management (2 of 2)
HD-DEN-5980_Non Volatile Data Management (2 of 2)
2:05 pm

Dara Navaei

DEN-5980 added message IDs for HD NV operations

Options
    • -2
    • +12
    /MsgDefs.h
Friday 12 Feb 2021
12:37 pm

Dara Navaei

DEN-5980 added more message IDs for NV operations

Options
    • -0
    • +3
    /MsgDefs.h
9:24 am

qnguyen  (deleted user)

Do we need to reset alarm signal flags?

Do we need to reset alarm signal flags?

Thursday 11 Feb 2021
4:15 pm

Dara Navaei

DEN-5980 added more message IDs for NV operations

Options
    • -0
    • +3
    /MsgDefs.h
  2. … 1 more file in changeset.