· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:24:08 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Jashwant Gantyada and Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-4409-2 LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1: ]]> Tue, 16 Jun 2026 13:23:38 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=cabab4c56b6840c94126b71696d2c95011cb01a0 https://devapps.diality.us/changelog/dd-firmware?cs=cabab4c56b6840c94126b71696d2c95011cb01a0 Vendor - TEL - Sameer Poyil committed cabab4c on branch LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more in dd-firmware LDT-4409 addressed review comments

· /firmware/App/Controllers/DryBiCart.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-2, +5)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 13:16:47 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-4409-2 LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1: ]]> Tue, 16 Jun 2026 11:55:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2/#c29958 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2/#c29958 Vinayakam Mani replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4409-2

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

I will mark it as TODO , so you can close it

Update name.

Add a Todo comment to resolve the issue.

Align the indentation.

Align the indentation.

Do we need these comments? delete it if not required.

Align the indent

· /firmware/App/Controllers/MixingControl.c	(-41, +43)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-2, +4)	| History	| Source	| Diff

]]> Tue, 16 Jun 2026 07:02:55 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=f364406cd1f672078ca38ae8aad5bc508e9b64dd https://devapps.diality.us/changelog/dd-firmware?cs=f364406cd1f672078ca38ae8aad5bc508e9b64dd Vendor - TEL - Sameer Poyil committed f364406 on branch LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more in dd-firmware LDT-4409 addressed review comments

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-16, +11)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.c	(-23, +46)	| History	| Source	| Diff
· /firmware/App/Controllers/MixingControl.h	(-2, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-1, +1)	| History	| Source	| Diff

]]> Mon, 15 Jun 2026 14:17:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2/#c29937 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4409-2/#c29937 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4409-2

Remove empty line

Remove unused header files.

Remove empty line.

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

Initialize result to open loop state and remove the open loop state assignment later.

Remove the blank line

Add headers for all below functions.

Rmove extra blank line

Update Input section: Balancing chamber state

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

remove min in the comment.

Remove the unused header file.

Remove the unused header file.

Update state name matching handler name.

Same as above.