LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW...

Activity

LEAHI-DD-FIRMWARE-LDT-4409-2 44

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 3h 31m 4 We need to keep D64 opened after supply to maintain the s...
    Reviewer - 50% reviewed 2h 41m 38 Michaels latest code resolved this issue. make sure when ...
    Reviewer - 6% reviewed 0m    
    Reviewer - 0% reviewed 5m    
    Reviewer - 0% reviewed 0m    
    Reviewer - 5% reviewed 1m 2 remove blank lines
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   6h 20m 44  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/.../Controllers/BalancingChamber.c Changed 2
    Open in IDE #permalink
    /firmware/.../Controllers/ConcentratePumps.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/DryBiCart.c Changed 24
    Open in IDE #permalink
    /firmware/App/Controllers/DryBiCart.h Changed 1
    Open in IDE #permalink
    /firmware/App/Controllers/MixingControl.c Added 13
    Open in IDE #permalink
    /firmware/App/Controllers/MixingControl.h Added 1
    Open in IDE #permalink
    /firmware/App/Drivers/TemperatureSensors.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModePreGenDialysate.c Changed
    Open in IDE #permalink
    /firmware/App/Monitors/Conductivity.c Changed 1
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed
    Open in IDE #permalink
    /firmware/App/Services/TDInterface.c Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskGeneral.c Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskPriority.c Changed 2
    Open in IDE #permalink
    /DDDefs.h Changed
    Open in IDE #permalink
    /MsgDefs.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time