dd-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 10
Total Committers: 14
Last Commit: 14:02
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Vendor - TEL - Arpita Srivastava

Minor: Inputs

Minor: Inputs

3 mins ago

Sean Nash

20 mins ago

Vinayakam Mani

Done

Done

20 mins ago

Vinayakam Mani

Done.

Done.

48 mins ago

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

49 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

49 mins ago

Sean Nash

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

52 mins ago

Sean Nash

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

55 mins ago

Sean Nash

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

57 mins ago

Sean Nash

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().

58 mins ago

Sean Nash

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

2 hrs ago

Vendor - TEL - Arpita Srivastava

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

2 hrs ago

Vendor - TEL - Arpita Srivastava

Please change bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE to BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

2 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

2 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

2 hrs ago

Vendor - TEL - Arpita Srivastava

Please remove extra line

Please remove extra line

2 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

2 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: Need space between parentheses

Minor: Need space between parentheses

2 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: Need space between parentheses

Minor: Need space between parentheses

3 hrs ago

Vinayakam Mani

Remove the empty space.

Remove the empty space.

3 hrs ago

Vinayakam Mani

Can we remove this #if check? we can keep the comment.

Can we remove this #if check? we can keep the comment.

3 hrs ago

Vinayakam Mani

can we get each group of level check in to a function and call those functions for each case?

can we get each group of level check in to a function and call those functions for each case?

3 hrs ago

Vendor - TEL - Arpita Srivastava

Minor: Please add space in [cmd].

Minor: Please add space in [cmd].

3 hrs ago

Vendor - TEL - Arpita Srivastava

Should it be bloodLeakEmbModeCmd?

Should it be bloodLeakEmbModeCmd?

4 hrs ago

Dara Navaei

7 hrs ago

Raghu Kallala

8 hrs ago

Sean Nash and Michael Garthwaite

8 hrs ago

Vendor - TEL - Jashwant Gantyada

changed.

changed.

Tuesday 10 Feb
5:25 pm

Sean Nash

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

Remove blank line.

Remove blank line.