Monitors

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Minor: Inputs

Minor: Inputs

Done

Done

Done.

Done.

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

Remove extra blank line.

Remove extra blank line.

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

Please change bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE to BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Please remove extra line

Please remove extra line

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space between parentheses

Minor: Need space between parentheses

Minor: Need space between parentheses

Minor: Need space between parentheses

Remove the empty space.

Remove the empty space.

Can we remove this #if check? we can keep the comment.

Can we remove this #if check? we can keep the comment.

can we get each group of level check in to a function and call those functions for each case?

can we get each group of level check in to a function and call those functions for each case?

Minor: Please add space in [cmd].

Minor: Please add space in [cmd].

Should it be bloodLeakEmbModeCmd?

Should it be bloodLeakEmbModeCmd?

changed.

changed.

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

Remove blank line.

Remove blank line.