dd-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 5
Total Committers: 14
Last Commit: 18 May
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:23 pm

Sean Nash

Now it's backward. You have to change the ENABLE to DISABLE too.

Now it's backward. You have to change the ENABLE to DISABLE too.

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

11:06 pm

Sean Nash

There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?

There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?

10:59 pm

Sean Nash

Should we set this flag to FALSE at top of loop?

Should we set this flag to FALSE at top of loop?

10:58 pm

Sean Nash

Should we just set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

10:50 pm

Sean Nash

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

10:47 pm

Sean Nash

Update comment.

Update comment.

10:46 pm

Sean Nash

Is this eventually going to be d1Temp?

Is this eventually going to be d1Temp?

Friday 15 May
11:36 am

Vinayakam Mani

align the indent.

align the indent.

11:33 am

Vinayakam Mani

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

11:25 am

Vendor - TEL - Jashwant Gantyada

merged LDT-3963 and resolved merge conflicts

Options
    • -1
    • +1
    ./Level.c
  2. … 2 more files in changeset.
Thursday 14 May
7:21 pm

Vendor - TEL - Sameer Poyil

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

6:02 pm

Vendor - TEL - Sameer Poyil

5:44 pm

Vinayakam Mani

LDT-3958 heater control update

Options
    • -1
    • +1
    ./Level.c
    • -1
    • +1
    ./Level.h
  3. … 4 more files in changeset.
2:36 pm

Vendor - TEL - Jashwant Gantyada

I had this commented again to push to the develop branch. It is uncommented for my testing.

I had this commented again to push to the develop branch. It is uncommented for my testing.

2:34 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Options
    • -1
    • +1
    ./Level.c
  2. … 1 more file in changeset.
2:31 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-3963 into develop

Options
    • -1
    • +1
    ./Level.c
  2. … 6 more files in changeset.
2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

makes sense. removed it.