dgfirmware

Clone Tools

Stats

Commits this week: 5
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Feb 2021
10:21 am

Quang Nguyen <qnguyen@diality.com>

DEN-6402: Addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +5
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
10:16 am

Sean Nash

May be moot after change to flow control.

May be moot after change to flow control.

10:11 am

Sean Nash

Yes, if drain pump is pumping too fast, the combined flow from drain pump and from RO pump is too much for the length of tubing after the two merge and go to drain. Starts to cavitate and causes a ...

Yes, if drain pump is pumping too fast, the combined flow from drain pump and from RO pump is too much for the length of tubing after the two merge and go to drain. Starts to cavitate and causes a lot of turbulence.

10:11 am

qnguyen  (deleted user)

This is our desired flow rate that we would like the controller to achieve.

This is our desired flow rate that we would like the controller to achieve.

10:10 am

qnguyen  (deleted user)

This is doxygen style comment if not in the same line.

This is doxygen style comment if not in the same line.

10:10 am

qnguyen  (deleted user)

This is doxygen style comment if not in the same line.

This is doxygen style comment if not in the same line.

10:05 am

Sean Nash

Doxygen needs /// (previous line) or ///< (same line) or it won't pick up the comment.

Doxygen needs /// (previous line) or ///< (same line) or it won't pick up the comment.

10:04 am

pmontazemi  (deleted user)

Remove extra "/" from comment.

Remove extra "/" from comment.

10:04 am

pmontazemi  (deleted user)

Remove extra "/" from comment.

Remove extra "/" from comment.

10:04 am

pmontazemi  (deleted user)

Remove extra "/" from comment.

Remove extra "/" from comment.

10:03 am

pmontazemi  (deleted user)

Is this initial RO pump target flow rate or this is fixed? If initial, we should indicate as this will be set by controller to achieve desired flow rate.

Is this initial RO pump target flow rate or this is fixed? If initial, we should indicate as this will be set by controller to achieve desired flow rate.

10:03 am

qnguyen  (deleted user)

Removed.

Removed.

10:02 am

qnguyen  (deleted user)

This is a doxygen style comment. Not a general code comment.

This is a doxygen style comment. Not a general code comment.

10:01 am

qnguyen  (deleted user)

Fixed. Elements inside typedef will not finish with ".".

Fixed. Elements inside typedef will not finish with ".".

10:01 am

pmontazemi  (deleted user)

Remove extra "/" in comment.

Remove extra "/" in comment.

10:00 am

pmontazemi  (deleted user)

Remove "to" from sentence.

Remove "to" from sentence.

9:57 am

qnguyen  (deleted user)

Those valve settings might not be of interest to the HD and should stay local to DG. For now, HD is interest in these two valve settings for wet self-tests.

Those valve settings might not be of interest to the HD and should stay local to DG.
For now, HD is interest in these two valve settings for wet self-tests.

9:56 am

qnguyen  (deleted user)

These have been defined both in DG and HD before and now moved here as a common define.

These have been defined both in DG and HD before and now moved here as a common define.

9:54 am

pmontazemi  (deleted user)

Do we finish comments with "." or not? Let us be consistent throughout.

Do we finish comments with "." or not? Let us be consistent throughout.

9:53 am

pmontazemi  (deleted user)

Isn't this already defined somewhere else? It seems redundant.

Isn't this already defined somewhere else? It seems redundant.

9:53 am

pmontazemi  (deleted user)

I would imagine there will be many more valve settings for the various modes/states and sub-modes/sub-states.

I would imagine there will be many more valve settings for the various modes/states and sub-modes/sub-states.

9:53 am

qnguyen  (deleted user)

We have slowed down the RO pump flow rate for drain mode. so the RO pump flow rate should not affect the drain process much.

We have slowed down the RO pump flow rate for drain mode. so the RO pump flow rate should not affect the drain process much.

9:41 am

qnguyen  (deleted user)

SYS team would like to lower down RPM since there is a risk of making the drain pump goes bad at 2800 RPM.

SYS team would like to lower down RPM since there is a risk of making the drain pump goes bad at 2800 RPM.

9:40 am

qnguyen  (deleted user)

Added maximum 5 times retry before alarm.

Added maximum 5 times retry before alarm.

9:39 am

Quang Nguyen <qnguyen@diality.com>

DEN-6402: Added alarm for RO pump ramp up retry fail

Options
    • -0
    • +8
    /firmware/App/Controllers/ROPump.c
9:14 am

qnguyen  (deleted user)

In verify state, we change the target pressure with the average pressure over the verify period. That pressure value is in float. For RO pump publish data, the data type for target pressure is floa...

In verify state, we change the target pressure with the average pressure over the verify period. That pressure value is in float.
For RO pump publish data, the data type for target pressure is float as well.

9:12 am

Dara Navaei

For the time that the RO pump is switching between ramp and stabilize to get to the flow, the drain continues, does that affect the drain process?

For the time that the RO pump is switching between ramp and stabilize to get to the flow, the drain continues, does that affect the drain process?

9:06 am

Dara Navaei

Why the RPM has been lowered?

Why the RPM has been lowered?

9:02 am

Dara Navaei

Do we need any persistent alarm after a couple of trials? How many times are you planning to go back and forth?

Do we need any persistent alarm after a couple of trials? How many times are you planning to go back and forth?

8:56 am

Dara Navaei

Are we planning to provide pressure in float? Like 30.25 psi?

Are we planning to provide pressure in float? Like 30.25 psi?