dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Feb 2021
1:18 pm

Quang Nguyen <qnguyen@diality.com>

DEN-6402: Fixed load cell tare reset between tare requests

Options
    • -1
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -25
    • +47
    /firmware/App/Services/PIControllers.c
12:38 pm

Dara Navaei

DEN-5980 added more commands to send and receive NV data

Options
    • -0
    • +9
    /firmware/.launches/DG.launch
    • -0
    • +6
    /firmware/App/Modes/ModeInitPOST.c
    • -4
    • +28
    /firmware/App/Services/SystemComm.c
    • -21
    • +315
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +29
    /firmware/App/Services/SystemCommMessages.h
    • -3
    • +7
    /firmware/App/Tasks/TaskGeneral.c
    • -1
    • +1
    /firmware/App/Tasks/TaskPriority.c
Thursday 11 Feb 2021
10:59 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Quang Nguyen <qnguyen@diality.com>

DEN-6402: Addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +5
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
10:16 am

Sean Nash

May be moot after change to flow control.

May be moot after change to flow control.

10:11 am

Sean Nash

Yes, if drain pump is pumping too fast, the combined flow from drain pump and from RO pump is too much for the length of tubing after the two merge and go to drain. Starts to cavitate and causes a ...

Yes, if drain pump is pumping too fast, the combined flow from drain pump and from RO pump is too much for the length of tubing after the two merge and go to drain. Starts to cavitate and causes a lot of turbulence.

10:11 am

qnguyen  (deleted user)

This is our desired flow rate that we would like the controller to achieve.

This is our desired flow rate that we would like the controller to achieve.

10:10 am

qnguyen  (deleted user)

This is doxygen style comment if not in the same line.

This is doxygen style comment if not in the same line.

10:10 am

qnguyen  (deleted user)

This is doxygen style comment if not in the same line.

This is doxygen style comment if not in the same line.

10:05 am

Sean Nash

Doxygen needs /// (previous line) or ///< (same line) or it won't pick up the comment.

Doxygen needs /// (previous line) or ///< (same line) or it won't pick up the comment.

10:04 am

pmontazemi  (deleted user)

Remove extra "/" from comment.

Remove extra "/" from comment.

10:04 am

pmontazemi  (deleted user)

Remove extra "/" from comment.

Remove extra "/" from comment.

10:04 am

pmontazemi  (deleted user)

Remove extra "/" from comment.

Remove extra "/" from comment.

10:03 am

pmontazemi  (deleted user)

Is this initial RO pump target flow rate or this is fixed? If initial, we should indicate as this will be set by controller to achieve desired flow rate.

Is this initial RO pump target flow rate or this is fixed? If initial, we should indicate as this will be set by controller to achieve desired flow rate.

10:03 am

qnguyen  (deleted user)

Removed.

Removed.

10:02 am

qnguyen  (deleted user)

This is a doxygen style comment. Not a general code comment.

This is a doxygen style comment. Not a general code comment.

10:01 am

qnguyen  (deleted user)

Fixed. Elements inside typedef will not finish with ".".

Fixed. Elements inside typedef will not finish with ".".