Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 19 Feb 2021

1:34 am

Quang Nguyen <qnguyen@diality.com>

More
b631516
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 217 more DG-DEN-7091-1

DEN-7091: Added water sample command handler

- -26
- +141
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +1
/firmware/App/Modes/ModeStandby.h
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.h
- -4
- +0
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -5
- +6
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

Wednesday 17 Feb 2021

8:29 pm

Dara Navaei

More
d4b0468
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 218 more DG-DEN-5980-1

DEN-5980 added or removed some of the states

- -1
- +1
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -6
- +6
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c
- -10
- +1
/firmware/App/Controllers/LoadCell.h
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.h
- -0
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h
- -4
- +6
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

10:36 am

Sean Nash

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

qnguyen (deleted user)

More
Re: DG-DEN-6402-1
replied to Sean Nash

This should be part of Non-Volatile Data Management code review. Dara Navaei has added them to the alarm table.

This should be part of Non-Volatile Data Management code review.
Dara Navaei has added them to the alarm table.

10:25 am

qnguyen (deleted user)

More
Re: DG-DEN-6402-1
replied to Sean Nash

These have been uncommented.

These have been uncommented.

9:25 am

Sean Nash

More
Re: DG-DEN-6402-1
commented on review

Why commented out?

Why commented out?

9:24 am

Sean Nash

More
Re: DG-DEN-6402-1
commented on review

Need to add these to end of alarm table below.

Need to add these to end of alarm table below.

Tuesday 16 Feb 2021

10:57 pm

Dara Navaei

More
787312b
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 218 more DG-DEN-5980-1

DEN-5980 removed old calibration commands

- -1
- +1
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -0
- +2
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -4
- +0
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -27
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -3
- +0
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

10:56 pm

pmontazemi (deleted user)

More
DG-DEN-6402-1
resumed reviewing

Friday 12 Feb 2021

1:18 pm

Quang Nguyen <qnguyen@diality.com>

More
64b37cc
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 220 more DG-DEN-5963-1 DG-DEN-5980-1 DG-DEN-6402-1

DEN-6402: Fixed load cell tare reset between tare requests

- -1
- +2
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c
- -25
- +47
/firmware/App/Services/PIControllers.c
- History
- Source
- Diff
/firmware/App/Services/PIControllers.c

12:38 pm

Dara Navaei

More
cb58615
changed 7 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 218 more DG-DEN-5980-1

DEN-5980 added more commands to send and receive NV data

- -0
- +9
/firmware/.launches/DG.launch
- History
- Source
- Diff
/firmware/.launches/DG.launch
- -0
- +6
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -4
- +28
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -21
- +315
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -2
- +29
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h
- -3
- +7
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c
- -1
- +1
/firmware/App/Tasks/TaskPriority.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskPriority.c

Thursday 11 Feb 2021

10:59 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:58 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi (deleted user)

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Sean Nash

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Dara Navaei

More
Re: DG-DEN-6402-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Dara Navaei

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

More
Re: DG-DEN-6402-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Quang Nguyen <qnguyen@diality.com>

More
0c1f66a
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 220 more DG-DEN-6402-1 DG-DEN-5963-1

DEN-6402: Addressed code review comments

- -1
- +1
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -5
- +5
/firmware/App/Controllers/LoadCell.c
- History
- Source
- Diff
/firmware/App/Controllers/LoadCell.c
- -1
- +1
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +1
/firmware/App/Modes/ModeDrain.c
- History
- Source
- Diff
/firmware/App/Modes/ModeDrain.c

10:16 am

Sean Nash

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

May be moot after change to flow control.

May be moot after change to flow control.

10:11 am

Sean Nash

More
Re: DG-DEN-6402-1
replied to qnguyen (deleted user)

Yes, if drain pump is pumping too fast, the combined flow from drain pump and from RO pump is too much for the length of tubing after the two merge and go to drain. Starts to cavitate and causes a ...

Yes, if drain pump is pumping too fast, the combined flow from drain pump and from RO pump is too much for the length of tubing after the two merge and go to drain. Starts to cavitate and causes a lot of turbulence.

10:11 am

qnguyen (deleted user)

More
Re: DG-DEN-6402-1
replied to pmontazemi (deleted user)

This is our desired flow rate that we would like the controller to achieve.

This is our desired flow rate that we would like the controller to achieve.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-13 12:58 -0800